From kde-kimageshop  Tue Jan 05 07:58:12 2010
From: Boudewijn Rempt <boud () valdyas ! org>
Date: Tue, 05 Jan 2010 07:58:12 +0000
To: kde-kimageshop
Subject: Re: koffice/plugins/colorengines/lcms/colorspaces/rgb_u8
Message-Id: <201001050858.13805.boud () valdyas ! org>
X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=126267834425132

On Monday 04 January 2010, Edward Apap wrote:
> SVN commit 1070109 by eapap:
> 
> Remove alpha channel manipulation after copying


I actually think that this is a legacy code path that is no longer used -- the 
real composite op copy is in libs/pigment/KoCompositeOpCopyAbstract.h. The 
only composite ops from that file that are still used are 

COMPOSITE_DARKEN
COMPOSITE_LIGHTEN
COMPOSITE_HUE
COMPOSITE_SATURATION
COMPOSITE_VALUE
COMPOSITE_COLOR
COMPOSITE_IN
COMPOSITE_OUT
COMPOSITE_DIFF
COMPOSITE_BUMPMAP
COMPOSITE_CLEAR
COMPOSITE_DISSOLVE

The rest really should be removed, and the legacy composite ops should be 
moved out of this file and made generic, where possible.


-- 
Boudewijn Rempt | http://www.valdyas.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop