[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: krita/koffice registries patch [2/2]
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2009-12-31 14:51:36
Message-ID: Pine.LNX.4.64.0912311550430.25381 () calcifer ! valdyas ! org
[Download RAW message or body]

On Thu, 31 Dec 2009, Thomas Zander wrote:

> We have a lot more registries than 2 years ago and because of Windows compiler
> all of those are forced to have a name() method, while nobody outside of krita 
> uses that at all.
> I did the research today and see 2 registries using KoID and thus name() 
> inside of Krita. There are 12 registries in koffice/libs and only the colorSpace 
> one (pigment) uses KoID.
> 
> So, what about moving the listKeys() method to the registry that actually uses
> it? It means duplicating 4 lines of code 3 times, but it frees up much much 
> more than that by making clear that just because its a factory it doesn't mean 
> it requires a user-visible name.
> The majority of the removing of this code is not in this patch, btw. Just a 
> small part.

I don't like the duplication much :-). But in general, I am fine with it.

Boudewijn

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]