[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: New Plasma modules and localization
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2020-05-16 14:22:51
Message-ID: CAGeFrHA1-uVQPQRUU-m68H7W=oknejad2o9Y0LWL7R2Z=-KrRw () mail ! gmail ! com
[Download RAW message or body]

>
> > It is sad, however, to see some regressions in translations. I cannot
> test by
> > myself but there are reports that some parts of the new KWin Rules KCM
> are
> > untranslatable:
> >
> > https://phabricator.kde.org/D29413
> >
> > Can somebody test if it's true?
>

Reading the code I can't immediately see any reason why it would be true.

>
> > The new ksysguard translations are broken. Extraction scripts do not
> work.
> >
> > $XGETTEXT *.cpp -o ksysguard_plugins_global.pot
> >  $XGETTEXT *.cpp -o ksysguard_plugins_process.pot
> >
> > should be replaced with
> >
> > $XGETTEXT `find -name \*.cpp` -o $podir/ksysguard_plugins_global.pot
> > $XGETTEXT `find -name \*.cpp` -o $podir/ksysguard_plugins_process.pot
> >
>
Indeed. That's on me. Sorry.

Will push when git KDE works again.
Thanks


> > The root localization of libksysguard is broken as well.
> >
> > Messages.sh extracts to KSysGuardSensorFaces.pot, QML code contains
> something
> > like i18nd("KSysGuardSensorFaces", "Remove") but CMakeLists.txt points
> to
> > add_definitions(-DTRANSLATION_DOMAIN=\"ksysguard_faces\")
> >
>

Shouldn't be a huuge issue, only the c++ code uses the add_definitions and
that's for anything UI user facing.
Will fix anyway.


> > What should be used for this to work as expected?
> >
> > (Spotted by Victor Ryzhykh)
> >
> > Thanks in advance for your answers.
>
> Plasma people, please test translations using the x-test locale before any
> change.
>

Can someone link to some docs on how to do that?
I can find are some docs for how to actually run Messages.sh and confirm
there's some files and some docs on how to run with x-test after
translations are downloaded.

Regards

David

[Attachment #3 (text/html)]

<div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> &gt; It is sad, however, to see some regressions \
in translations. I cannot test by <br> &gt; myself but there are reports that some \
parts of the new KWin Rules KCM are <br> &gt; untranslatable:<br>
&gt; <br>
&gt; <a href="https://phabricator.kde.org/D29413" rel="noreferrer" \
target="_blank">https://phabricator.kde.org/D29413</a><br> &gt; <br>
&gt; Can somebody test if it&#39;s true?<br></blockquote><div><br></div><div>Reading \
the code I can&#39;t immediately see any reason why it would be \
true.</div><div></div><div></div><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> &gt; <br>
&gt; The new ksysguard translations are broken. Extraction scripts do not work.<br>
&gt; <br>
&gt; $XGETTEXT *.cpp -o ksysguard_plugins_global.pot<br>
&gt;   $XGETTEXT *.cpp -o ksysguard_plugins_process.pot<br>
&gt; <br>
&gt; should be replaced with<br>
&gt; <br>
&gt; $XGETTEXT `find -name \*.cpp` -o $podir/ksysguard_plugins_global.pot<br>
&gt; $XGETTEXT `find -name \*.cpp` -o $podir/ksysguard_plugins_process.pot<br>
&gt; <br></blockquote><div>Indeed. That&#39;s on me. \
Sorry.</div><div><br></div><div>Will push when git KDE works \
again.</div><div>Thanks<br></div><div>  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> &gt; The root localization of libksysguard is \
broken as well.<br> &gt; <br>
&gt; Messages.sh extracts to KSysGuardSensorFaces.pot, QML code contains something \
<br> &gt; like i18nd(&quot;KSysGuardSensorFaces&quot;, &quot;Remove&quot;) but \
CMakeLists.txt points to <br> &gt; \
add_definitions(-DTRANSLATION_DOMAIN=\&quot;ksysguard_faces\&quot;)<br> &gt; \
<br></blockquote><br></div><div class="gmail_quote">Shouldn&#39;t be a huuge issue, \
only the c++ code uses the add_definitions and that&#39;s for anything UI user \
facing.</div><div class="gmail_quote">Will fix anyway.<br></div><div \
class="gmail_quote"><div>  </div><blockquote class="gmail_quote" style="margin:0px \
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> &gt; What \
should be used for this to work as expected?<br> &gt; <br>
&gt; (Spotted by Victor Ryzhykh)<br>
&gt; <br>
&gt; Thanks in advance for your answers.<br>
<br>
Plasma people, please test translations using the x-test locale before any \
change.<br></blockquote></div><div class="gmail_quote"><br></div><div \
class="gmail_quote">Can someone link to some docs on how to do that?</div><div \
class="gmail_quote"></div><div class="gmail_quote">I can find are some docs for how \
to actually run Messages.sh and confirm there&#39;s some files and some docs on how \
to run with x-test after translations are downloaded. <br></div><div \
class="gmail_quote"><br></div><div class="gmail_quote">Regards<br></div><div \
class="gmail_quote"><br></div><div class="gmail_quote">David<br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]