[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 118801: Consider additional batteries for power management (
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2014-07-13 11:01:24
Message-ID: 20140713110124.3846.33105 () probe ! kde ! org
[Download RAW message or body]
--===============7665940878992940530==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 23, 2014, 4:47 p.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > 775a99e8bc1e9c5e277ff17a84a406227a5a32fb by Emmanuel Pescosta to branch KDE/4.11.
>
> Emmanuel Pescosta wrote:
> I'll create a patch for kde:powerdevil when I have some time again, maybe this \
> weekend or in the end of next week.
If you are done, please close bug 337414
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118801/#review60821
-----------------------------------------------------------
On June 23, 2014, 4:47 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118801/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 4:47 p.m.)
>
>
> Review request for Solid.
>
>
> Bugs: 325707 and 329537
> http://bugs.kde.org/show_bug.cgi?id=325707
> http://bugs.kde.org/show_bug.cgi?id=329537
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> After resuming from suspend, all batteries are added
> to powerdevil. When a battery, with charge lower or
> equal than the critical charge percentage is added, the
> critical battery timer will be started.
>
> In the current version the critical battery timeout can
> only be interrupted by plugging in AC.
>
> But if the system has more than one battery, the global
> charge percentage can be greater than the critical charge
> percentage and so the system shouldn't suspend. To achive
> this behaviour, we calculate the global charge percentage
> whenever a new battery was added and if the critical
> battery timer is running and the global charge is high
> enough, we stop the timer.
>
> Also we use the already calculated global charge percentage
> for the battery charge percentage notification instead of
> the charge of each individual battery.
>
> With this patch, the user can not only interrupt the critical
> timer by plugging in the AC but also by plugging in a new or
> additional battery (if the battery has enough charge).
>
>
> Note:
> The patch for kde:powerdevil will move the calculation of
> the global charge percentage into a new function to avoid
> the code duplication, but for the KDE/4.11 version I have
> avoided this to keep the number of changes as small as
> possible.
>
> The 30 sec timeout message will still popup. Any ideas
> how to avoid this? Showing an additional message is not
> a solution in this case because of the message freeze.
>
>
> Diffs
> -----
>
> powerdevil/daemon/powerdevilcore.cpp 76e1b82
>
> Diff: https://git.reviewboard.kde.org/r/118801/diff/
>
>
> Testing
> -------
>
> Testing was done by Philipp Paris on his Thinkpad T440s (two
> batteries).
>
> Two batteries above critical section:
> Resume after suspend works without the 30 sec timeout. (as current version)
>
> One battery in critical section and the other above:
> Resume after suspend works without the 30 sec timeout. (changed behaviour)
>
> Both in critical section:
> Resume after suspend without plugged in AC will go sleeping
> in 30 sec. (as current version)
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
--===============7665940878992940530==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118801/">https://git.reviewboard.kde.org/r/118801/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 23rd, 2014, 4:47 p.m. UTC, <b>Commit \
Hook</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
775a99e8bc1e9c5e277ff17a84a406227a5a32fb by Emmanuel Pescosta to branch \
KDE/4.11.</pre> </blockquote>
<p>On June 23rd, 2014, 4:50 p.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll create a patch \
for kde:powerdevil when I have some time again, maybe this weekend or in the end of \
next week.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you are done, please close bug 337414</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On June 23rd, 2014, 4:47 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Solid.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated June 23, 2014, 4:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325707">325707</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=329537">329537</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After resuming from suspend, all batteries are added to powerdevil. When \
a battery, with charge lower or equal than the critical charge percentage is added, \
the critical battery timer will be started.
In the current version the critical battery timeout can
only be interrupted by plugging in AC.
But if the system has more than one battery, the global
charge percentage can be greater than the critical charge
percentage and so the system shouldn't suspend. To achive
this behaviour, we calculate the global charge percentage
whenever a new battery was added and if the critical
battery timer is running and the global charge is high
enough, we stop the timer.
Also we use the already calculated global charge percentage
for the battery charge percentage notification instead of
the charge of each individual battery.
With this patch, the user can not only interrupt the critical
timer by plugging in the AC but also by plugging in a new or
additional battery (if the battery has enough charge).
Note:
The patch for kde:powerdevil will move the calculation of
the global charge percentage into a new function to avoid
the code duplication, but for the KDE/4.11 version I have
avoided this to keep the number of changes as small as
possible.
The 30 sec timeout message will still popup. Any ideas
how to avoid this? Showing an additional message is not
a solution in this case because of the message freeze.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing was done by Philipp Paris on his Thinkpad T440s (two batteries).
Two batteries above critical section:
Resume after suspend works without the 30 sec timeout. (as current version)
One battery in critical section and the other above:
Resume after suspend works without the 30 sec timeout. (changed behaviour)
Both in critical section:
Resume after suspend without plugged in AC will go sleeping
in 30 sec. (as current version)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/powerdevilcore.cpp <span style="color: \
grey">(76e1b82)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118801/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7665940878992940530==--
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic