[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 107257: Handle unsupported actions quietly
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2013-05-15 18:45:51
Message-ID: 20130515184551.3764.56406 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 5, 2013, 10:36 p.m., Kai Uwe Broulik wrote:
> > Ping?
Wednesday is Feature Freeze for 4.11!
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107257/#review32113
-----------------------------------------------------------
On Nov. 21, 2012, 7:20 p.m., Oliver Henshaw wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107257/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2012, 7:20 p.m.)
>
>
> Review request for Solid.
>
>
> Description
> -------
>
> Handle unsupported actions quietly
>
> Attempting to load a configured action on a machine where it is not
> supported (e.g. DPMS when the display doesn't support it or it is not
> compiled in) fails and brings up a notification, something that is
> particularly intrusive during login.
>
> Provide a method for ActionPool::loadAction callers to ask why the load
> failed. PowerDevil::Core::loadProfile uses this check to decide whether
> to warn to stderr rather than notifying the user of a misconfiguration.
> Other loadAction callers are unchanged.
>
> Action loading failure may be due to an error during initialisation or
> simply because no such action exits. In the former case the error must
> be recorded so that it is available to pass on to later loadAction
> callers.
>
> NB: A more complete fix might involve detecting whether the action is
> supportable when loading the action configuration and/or in the profile
> generator. However that may not turn out to be a feasible approach.
>
> BUG: 302846
>
>
> Diffs
> -----
>
> powerdevil/daemon/powerdevilactionpool.h 8a94eacc8ef2c2aead8cb075cbc80b783c1aeb4c
> powerdevil/daemon/powerdevilactionpool.cpp a9950f174fe184b8faa54c54fc00654984c65b3f \
> powerdevil/daemon/powerdevilcore.cpp 2dcdbc62236d5c1fae384fdb9111825a2ebf5204
>
> Diff: http://git.reviewboard.kde.org/r/107257/diff/
>
>
> Testing
> -------
>
> Tested in VM with cirrus/vnc (dpms) and qxl/spice (non-dpms) graphics. Tested the \
> NoAction and LoadFailed cases act as expected. Tested nothing horrible happens when \
> disabling and re-enabling powerdevil in kded Services Manager.
>
> Thanks,
>
> Oliver Henshaw
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107257/">http://git.reviewboard.kde.org/r/107257/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 5th, 2013, 10:36 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ping?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wednesday is Feature \
Freeze for 4.11!</pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On November 21st, 2012, 7:20 p.m. UTC, Oliver Henshaw wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid.</div>
<div>By Oliver Henshaw.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2012, 7:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Handle unsupported actions quietly
Attempting to load a configured action on a machine where it is not
supported (e.g. DPMS when the display doesn't support it or it is not
compiled in) fails and brings up a notification, something that is
particularly intrusive during login.
Provide a method for ActionPool::loadAction callers to ask why the load
failed. PowerDevil::Core::loadProfile uses this check to decide whether
to warn to stderr rather than notifying the user of a misconfiguration.
Other loadAction callers are unchanged.
Action loading failure may be due to an error during initialisation or
simply because no such action exits. In the former case the error must
be recorded so that it is available to pass on to later loadAction
callers.
NB: A more complete fix might involve detecting whether the action is
supportable when loading the action configuration and/or in the profile
generator. However that may not turn out to be a feasible approach.
BUG: 302846</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in VM with cirrus/vnc (dpms) and qxl/spice (non-dpms) graphics. \
Tested the NoAction and LoadFailed cases act as expected. Tested nothing horrible \
happens when disabling and re-enabling powerdevil in kded Services Manager.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/powerdevilactionpool.h <span style="color: \
grey">(8a94eacc8ef2c2aead8cb075cbc80b783c1aeb4c)</span></li>
<li>powerdevil/daemon/powerdevilactionpool.cpp <span style="color: \
grey">(a9950f174fe184b8faa54c54fc00654984c65b3f)</span></li>
<li>powerdevil/daemon/powerdevilcore.cpp <span style="color: \
grey">(2dcdbc62236d5c1fae384fdb9111825a2ebf5204)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107257/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic