This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/

Review request for kde-workspace.
By Danny Baumann.

Description

This change does two things:
- No longer dim display before the dim time set by the user elapses.
  This fixes bug #304696
- No longer assume that 0% display brightness produces a visible result.
  This doesn't work with the intel-backlight backlight interface (as it
  turns off the backlight at 0% brightness). According to the kernel
  developers (see [1] and [2]), this isn't a safe assumption to make for
  other backlight interfaces either. Instead of always dimming to 0%,
  make the amount of dimming configurable.

[1]
http://lists.freedesktop.org/archives/intel-gfx/2013-March/026152.html
[2]
http://lists.freedesktop.org/archives/intel-gfx/2013-March/026140.html
Bugs: 304696

Diffs

  • powerdevil/daemon/actions/bundled/dimdisplay.h (426640ca7a2a2d23044052710fdfb4b1f65617d1)
  • powerdevil/daemon/actions/bundled/dimdisplay.cpp (11554e3ba5d2f67d4d1de9d61c744c6c40a32d27)
  • powerdevil/daemon/actions/bundled/dimdisplayconfig.h (14b787937249a512cf958a31fd3bd71d6051540d)
  • powerdevil/daemon/actions/bundled/dimdisplayconfig.cpp (bc116d6216c4624cbf14489d739d9d226fb70ff3)

View Diff