[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D23112: Add a event Spy for GtkFileChooser recent files
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2019-08-12 12:27:29
Message-ID: 187e7854ca7996dbda6c070aa1f5e541 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added inline comments.

INLINE COMMENTS

> GtkEventSpy.cpp:125
> +
> +        app.name = attributes.value("exec");
> +        // remove "'" caracters wrapping the command and any character after a \
> space

It stores the full `Exec` line of the desktop file, including the `%u`.
What you probably want do to is use `KServiceTypeTrader` to find the application with \
said Exec line.

  auto services = KServiceTypeTrader::self()->query(QStringLiteral("Application"), \
QStringLiteral("exist Exec and ('%1' == Exec)").arg(cmd));

and then operate on the `KService` desktop file name, e.g. `org.gnome.evince` instead \
of the executable.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, \
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D23112">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D23112#inline-130325">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">GtkEventSpy.cpp:125</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="n">app</span><span class="p">.</span><span class="n">name</span> <span \
style="color: #aa2211">=</span> <span class="n">attributes</span><span \
class="p">.</span><span class="n">value</span><span class="p">(</span><span \
style="color: #766510">&quot;exec&quot;</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span style="color: #74777d">// remove &quot;&#39;&quot; caracters wrapping the \
command and any character after a space</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It \
stores the full <tt style="background: #ebebeb; font-size: 13px;">Exec</tt> line of \
the desktop file, including the <tt style="background: #ebebeb; font-size: \
13px;">%u</tt>.<br /> What you probably want do to is use <tt style="background: \
#ebebeb; font-size: 13px;">KServiceTypeTrader</tt> to find the application with said \
Exec line.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">auto services = \
KServiceTypeTrader::self()-&gt;query(QStringLiteral(&quot;Application&quot;), \
QStringLiteral(&quot;exist Exec and (&#039;%1&#039; == \
Exec)&quot;).arg(cmd));</pre></div>

<p style="padding: 0; margin: 8px;">and then operate on the <tt style="background: \
#ebebeb; font-size: 13px;">KService</tt> desktop file name, e.g. <tt \
style="background: #ebebeb; font-size: 13px;">org.gnome.evince</tt> instead of the \
executable.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R161 KActivity Manager \
Service</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D23112">https://phabricator.kde.org/D23112</a></div></div><br \
/><div><strong>To: </strong>meven, Frameworks, ivan<br /><strong>Cc: \
</strong>broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, \
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]