[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129381: kconfig fix kconfigskeletontest
From: Allen Winter <winter () kde ! org>
Date: 2017-08-30 16:08:05
Message-ID: 20170830160805.31785.73745 () mimi ! kde ! org
[Download RAW message or body]
--===============5329371184067170729==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129381/
-----------------------------------------------------------
(Updated Aug. 30, 2017, 4:08 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks.
Repository: kconfig
Description
-------
some kconfigskeletontest tests were failing. this patch fixes:
1) rename init() and cleanup() to initTestCase() and cleanupTestCase() by convention \
and to make sure they happen in the correct order 2) testRemoveItem() must come after \
testKConfigDirty() becuase it removes the item we test for dirtyness 3) fix \
testSaveRead()
Diffs
-----
autotests/kconfigskeletontest.h 5cdcc9d
autotests/kconfigskeletontest.cpp 898366c
Diff: https://git.reviewboard.kde.org/r/129381/diff/
Testing
-------
before some of the tests fail and now they all pass.
Thanks,
Allen Winter
--===============5329371184067170729==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129381/">https://git.reviewboard.kde.org/r/129381/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Allen Winter.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2017, 4:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">some kconfigskeletontest tests were failing. this \
patch fixes:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">1) rename init() and cleanup() to initTestCase() and \
cleanupTestCase() by convention and to make sure they happen in the correct order 2) \
testRemoveItem() must come after testKConfigDirty() becuase it removes the item we \
test for dirtyness 3) fix testSaveRead()</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">before some of the tests fail and now they all \
pass.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfigskeletontest.h <span style="color: grey">(5cdcc9d)</span></li>
<li>autotests/kconfigskeletontest.cpp <span style="color: \
grey">(898366c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129381/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5329371184067170729==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic