[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6624: do not crash qaccessible by causing a resize in a resize event
From:       Harald Sitter <noreply () phabricator ! kde ! org>
Date:       2017-07-11 12:09:55
Message-ID: 20170711120941.103513.BBFE7A9D6E9C07B8 () phabricator ! kde ! org
[Download RAW message or body]

sitter added a comment.


  In https://phabricator.kde.org/D6624#124077, @cfeck wrote:
  
  > Reading your description on the referenced QTBUG, does it help to use a compare \
with previous m_columns in KCharSelectItemModel ::setColumnCount() before doing the \
emit dance?  
  
  It probably does. To me, that would seem a bit too close to the cause though. If \
tomorrow another bit of the resizing calculation starts causing a re-layout it would \
crash again. That said, I think adding an `if` would be handy either way, what with \
saving a bunch of cpu cycles.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D6624

To: sitter, gladhorn
Cc: cfeck, anthonyfieroni, #frameworks


[Attachment #3 (unknown)]

<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6624" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6624#124077" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6624#124077</a>, <a \
href="https://phabricator.kde.org/p/cfeck/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@cfeck</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Reading your description on the referenced \
QTBUG, does it help to use a compare with previous m_columns in KCharSelectItemModel \
::setColumnCount() before doing the emit dance?</p></div> </blockquote>

<p>It probably does. To me, that would seem a bit too close to the cause though. If \
tomorrow another bit of the resizing calculation starts causing a re-layout it would \
crash again. That said, I think adding an <tt style="background: #ebebeb; font-size: \
13px;">if</tt> would be handy either way, what with saving a bunch of cpu \
cycles.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R236 \
KWidgetsAddons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6624" \
rel="noreferrer">https://phabricator.kde.org/D6624</a></div></div><br \
/><div><strong>To: </strong>sitter, gladhorn<br /><strong>Cc: </strong>cfeck, \
anthonyfieroni, Frameworks<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]