From kde-frameworks-devel Sun Jun 26 21:05:00 2016 From: Olivier Goffart Date: Sun, 26 Jun 2016 21:05:00 +0000 To: kde-frameworks-devel Subject: Re: Review Request 127926: KNotifyConfigWidget: add disableAllSounds() method Message-Id: <20160626210500.5107.65810 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=146697512911548 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5501769300057062582==" --===============5501769300057062582== Content-Type: multipart/alternative; boundary="===============1655211962833886048==" --===============1655211962833886048== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/#review95507 ----------------------------------------------------------- Ship it! What i see as a potential problem is that there is no quick way to enable them all again as it was before. - Olivier Goffart On May 15, 2016, 10:53 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127926/ > ----------------------------------------------------------- > > (Updated May 15, 2016, 10:53 a.m.) > > > Review request for KDE Frameworks, David Edmundson and Olivier Goffart. > > > Bugs: 157272 > https://bugs.kde.org/show_bug.cgi?id=157272 > > > Repository: knotifyconfig > > > Description > ------- > > This saves a lot of clicking compared to selecting each event > in the list and unchecking the "Play sound" checkbox, something > I have to do any time I set up a new computer (for me or around the office). > > CCBUG: 157272 > > > Diffs > ----- > > src/knotifyconfigwidget.h bf122bd9e30982f0fa0d022d04aeadee4fb181dc > src/knotifyconfigwidget.cpp 06125ea9da565cbc14c8afa1155c723605b42da6 > src/knotifyeventlist.h b6bd43ed40f9b2a18d41300760a6c01dca52907d > src/knotifyeventlist.cpp 6913148869a7be6b267668e44888f1a432b2396b > > Diff: https://git.reviewboard.kde.org/r/127926/diff/ > > > Testing > ------- > > I'm calling this method from a button in the KCM: http://www.davidfaure.fr/2016/kcmnotify.diff > > My initial idea was a "disable all sounds for all event sources" button, but the underlying classes don't make this easy to support (I'd have to literally set every item as current in the combo, leading to a strange user-visible automation happening). Disabling all sounds for the current event source (app) is already quite a time saver. > Plus this way the change isn't saved yet, it can still be cancelled by pressing Cancel, like any other change -except- selecting another app. > > > Thanks, > > David Faure > > --===============1655211962833886048== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127926/

Ship it!

What i see as a potential problem is that there is no quick way to enable them all again as it was before.

- Olivier Goffart

On May 15th, 2016, 10:53 a.m. UTC, David Faure wrote:

Review request for KDE Frameworks, David Edmundson and Olivier Goffart.

By David Faure.

Updated May 15, 2016, 10:53 a.m.

Bugs: 157272

Repository: knotifyconfig

Description

This saves a lot of clicking compared to selecting each event
in the list and unchecking the "Play sound" checkbox, something
I have to do any time I set up a new computer (for me or around the office).

CCBUG: 157272

Testing

I'm calling this method from a button in the KCM: http://www.davidfaure.fr/2016/kcmnotify.diff

My initial idea was a "disable all sounds for all event sources" button, but the underlying classes don't make this easy to support (I'd have to literally set every item as current in the combo, leading to a strange user-visible automation happening). Disabling all sounds for the current event source (app) is already quite a time saver. Plus this way the change isn't saved yet, it can still be cancelled by pressing Cancel, like any other change -except- selecting another app.

Diffs

src/knotifyconfigwidget.h (bf122bd9e30982f0fa0d022d04aeadee4fb181dc)
src/knotifyconfigwidget.cpp (06125ea9da565cbc14c8afa1155c723605b42da6)
src/knotifyeventlist.h (b6bd43ed40f9b2a18d41300760a6c01dca52907d)
src/knotifyeventlist.cpp (6913148869a7be6b267668e44888f1a432b2396b)

--===============1655211962833886048==-- --===============5501769300057062582== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============5501769300057062582==--