[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126684: fix loading of RLE compressed PSD files
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2016-01-09 10:12:02
Message-ID: 20160109101202.6499.85877 () mimi ! kde ! org
[Download RAW message or body]
--===============7958891971458664772==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126684/#review90811
-----------------------------------------------------------
I'm not the maintainer, but by checking krita's RLE code I can confirm the fix is \
correct.
- Boudewijn Rempt
On Jan. 9, 2016, 9:58 a.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126684/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 9:58 a.m.)
>
>
> Review request for KDE Frameworks and Alex Merry.
>
>
> Bugs: 354413
> https://bugs.kde.org/show_bug.cgi?id=354413
>
>
> Repository: kimageformats
>
>
> Description
> -------
>
> decodeRLEData() expects a quint16 as length, but the PSD loader calls it with a \
> quint32. We do need quint32 for PSD (it's the pixel count there, i.e. width x \
> height), otherwise it would overflow for files bigger than 256x256 pixels.
>
> Diffs
> -----
>
> src/imageformats/rle_p.h 71d6b2c
>
> Diff: https://git.reviewboard.kde.org/r/126684/diff/
>
>
> Testing
> -------
>
> RLE compressed PSD files now load fine in applications like (the KF5 based) \
> gwenview, kolourpaint and okular, thumbnails are shown correctly in dolphin too.
> PIC files still work as well.
>
> The tests still pass.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
--===============7958891971458664772==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126684/">https://git.reviewboard.kde.org/r/126684/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not the maintainer, but by checking krita's RLE code I can confirm the fix is \
correct.</p></pre> <br />
<p>- Boudewijn Rempt</p>
<br />
<p>On January 9th, 2016, 9:58 a.m. UTC, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2016, 9:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=354413">354413</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">decodeRLEData() expects a quint16 as length, but the \
PSD loader calls it with a quint32. We do need quint32 for PSD (it's the pixel count \
there, i.e. width x height), otherwise it would overflow for files bigger than \
256x256 pixels.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">RLE compressed PSD files now load fine in applications \
like (the KF5 based) gwenview, kolourpaint and okular, thumbnails are shown correctly \
in dolphin too.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">PIC files still work as well.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The tests still pass.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/imageformats/rle_p.h <span style="color: grey">(71d6b2c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126684/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7958891971458664772==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic