'Review Request 126675: Add .kra and .ora qimagio plugins'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 126675: Add .kra and .ora qimagio plugins
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2016-01-08 8:50:40
Message-ID: 20160108085040.6499.41671 () mimi ! kde ! org
[Download RAW message or body]

--===============8142546321438526418==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/
-----------------------------------------------------------

Review request for KDE Frameworks.

Repository: kimageformats

Description
-------

These qimageio plugins originally come from krita, but people who haven't got krita \
installed might want to view Krita or OpenRaster images as well. Both formats are \
really simple, just zip files with a png inside that represents the merged image. \
This patch does add a KF5::Archive dependency to kimageformats.

Diffs
-----

  CMakeLists.txt 1e7e703 
  src/imageformats/CMakeLists.txt 8cf8d54 
  src/imageformats/kra.cpp PRE-CREATION 
  src/imageformats/kra.desktop PRE-CREATION 
  src/imageformats/kra.h PRE-CREATION 
  src/imageformats/kra.json PRE-CREATION 
  src/imageformats/ora.cpp PRE-CREATION 
  src/imageformats/ora.desktop PRE-CREATION 
  src/imageformats/ora.h PRE-CREATION 
  src/imageformats/ora.json PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126675/diff/

Testing
-------

Thanks,

Boudewijn Rempt

--===============8142546321438526418==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126675/">https://git.reviewboard.kde.org/r/126675/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Boudewijn Rempt.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">These qimageio plugins originally come from krita, but \
people who haven't got krita installed might want to view Krita or OpenRaster images \
as well. Both formats are really simple, just zip files with a png inside that \
represents the merged image. This patch does add a KF5::Archive dependency to \
kimageformats.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(1e7e703)</span></li>

 <li>src/imageformats/CMakeLists.txt <span style="color: grey">(8cf8d54)</span></li>

 <li>src/imageformats/kra.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/kra.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/kra.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/kra.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/ora.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/ora.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/ora.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/ora.json <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126675/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8142546321438526418==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 