'Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-12-21 13:04:43
Message-ID: 20151221130443.32218.72507 () mimi ! kde ! org
[Download RAW message or body]

--===============5894506557797488006==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126230/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 1:04 p.m.)

Status
------

This change has been discarded.

Review request for Build System, KDE Frameworks, Aleix Pol Gonzalez, Chusslove \
Illich, and Luigi Toscano.

Repository: ki18n

Description
-------

When building ki18n as a dependency framework for shipping with an application, the \
tools to actually create and manage translations are superfluous. These tools have \
some big dependencies that are a pain to have around, especially gettext on Windows. \
This patch makes the requirement for Python and Gettext optional.

This patch checks the BUILD_TESTING variable to see if the autotests should be built, \
because when we just need the library to build an application we shouldn't waste \
electicity building the tests (and the Qt5::QML dependency).

Diffs
-----

  CMakeLists.txt 59917fa 
  cmake/KF5I18NMacros.cmake 53ba812 

Diff: https://git.reviewboard.kde.org/r/126230/diff/

Testing
-------

Thanks,

Boudewijn Rempt

--===============5894506557797488006==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126230/">https://git.reviewboard.kde.org/r/126230/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Build System, KDE Frameworks, Aleix Pol Gonzalez, Chusslove \
Illich, and Luigi Toscano.</div> <div>By Boudewijn Rempt.</div>

<p style="color: grey;"><i>Updated Dec. 21, 2015, 1:04 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When building ki18n as a dependency framework for \
shipping with an application, the tools to actually create and manage translations \
are superfluous. These tools have some big dependencies that are a pain to have \
around, especially gettext on Windows. This patch makes the requirement for Python \
and Gettext optional.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch checks the BUILD_TESTING \
variable to see if the autotests should be built, because when we just need the \
library to build an application we shouldn't waste electicity building the tests (and \
the Qt5::QML dependency).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(59917fa)</span></li>

 <li>cmake/KF5I18NMacros.cmake <span style="color: grey">(53ba812)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126230/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5894506557797488006==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 