'Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of d'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of d
From:       Jarosław_Staniek <staniek () kde ! org>
Date:       2015-11-30 17:05:33
Message-ID: 20151130170533.29696.11318 () mimi ! kde ! org
[Download RAW message or body]

--===============0130955345453648420==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126199/
-----------------------------------------------------------

(Updated Nov. 30, 2015, 5:05 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Alex Merry.

Changes
-------

Submitted with commit 18243570bcae0cf02a4a87eff2f1834500ae955d by Jaroslaw Staniek to \
branch master.

Repository: extra-cmake-modules

Description
-------

This change adds SVG(Z) extensions to the list of allowed icons for specific sizes.

This technically works and is practiced, e.g. for some Breeze icons.

Reasoning:
Some SVG icons do not scale well down from 32 to 22 or up from 16 to 22.
For such cases icons are typically specially crafted for 22 and 16, at least.
Then there's no single icon that be marked as "sc".

So warnings such as:

CMake Warning at ..../ECMInstallIcons.cmake:272 (message):
    Fixed-size icon foo.svg is not PNG or MNG

... are misleading.

Diffs
-----

  modules/ECMInstallIcons.cmake 549ebe1 

Diff: https://git.reviewboard.kde.org/r/126199/diff/

Testing
-------

ECM no longer warns for projects that use .svg icons of multiple variants (e.g. \
kreport.git master)

Thanks,

Jarosław Staniek

--===============0130955345453648420==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126199/">https://git.reviewboard.kde.org/r/126199/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Jarosław Staniek.</div>

<p style="color: grey;"><i>Updated Nov. 30, 2015, 5:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 18243570bcae0cf02a4a87eff2f1834500ae955d by \
Jaroslaw Staniek to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This change adds SVG(Z) extensions to the list of \
allowed icons for specific sizes.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This technically works \
and is practiced, e.g. for some Breeze icons.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Reasoning: Some SVG icons do not scale well down from 32 to 22 or up from \
16 to 22. For such cases icons are typically specially crafted for 22 and 16, at \
least. Then there's no single icon that be marked as "sc".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So warnings such as:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMake \
Warning at ..../ECMInstallIcons.cmake:272 (message):  Fixed-size icon foo.svg is not \
PNG or MNG</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">... are misleading.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ECM no longer warns for projects that use .svg icons \
of multiple variants (e.g. kreport.git master)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMInstallIcons.cmake <span style="color: grey">(549ebe1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126199/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0130955345453648420==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 