'Re: Review Request 125806: Fix build with -DDEFINE_NO_DEPRECATED=1'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125806: Fix build with -DDEFINE_NO_DEPRECATED=1
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-10-26 16:58:10
Message-ID: 20151026165810.14097.99955 () mimi ! kde ! org
[Download RAW message or body]

--===============7295262249973418086==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125806/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 4:58 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Christoph Feck.

Changes
-------

Submitted with commit 7d8b8417cbb6b8439b6689963758e2c20b091fac by Boudewijn Rempt to \
branch master.

Repository: kwidgetsaddons

Description
-------

With no-deprecated set, clang refuses to build kmultitabbar:

/Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:564:19: \
error: out-of-line definition of 'appendButton' does not match any  declaration in \
'KMultiTabBar' int KMultiTabBar::appendButton(const QPixmap &pic, int id, QMenu \
*popup, const QString &x)  ^~~~~~~~~~~~
/Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:593:19: \
error: out-of-line definition of 'appendTab' does not match any  declaration in \
'KMultiTabBar' int KMultiTabBar::appendTab(const QPixmap &pic, int id, const QString \
&text)  ^~~~~~~~~

Diffs
-----

  src/kmultitabbar.cpp 2327748 

Diff: https://git.reviewboard.kde.org/r/125806/diff/

Testing
-------

Thanks,

Boudewijn Rempt

--===============7295262249973418086==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125806/">https://git.reviewboard.kde.org/r/125806/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Boudewijn Rempt.</div>

<p style="color: grey;"><i>Updated Oct. 26, 2015, 4:58 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 7d8b8417cbb6b8439b6689963758e2c20b091fac by \
Boudewijn Rempt to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With no-deprecated set, clang refuses to build \
kmultitabbar:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">/Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:564:19: \
error: out-of-line definition of 'appendButton' does not match any  declaration in \
'KMultiTabBar' int KMultiTabBar::appendButton(const QPixmap &amp;pic, int id, QMenu \
*popup, const QString &amp;x)  ^~~~~~~~~~~~
/Users/boudewijnrempt/kf5/b/ext_frameworks/ext_kwidgetsaddons-prefix/src/ext_kwidgetsaddons/src/kmultitabbar.cpp:593:19: \
error: out-of-line definition of 'appendTab' does not match any  declaration in \
'KMultiTabBar' int KMultiTabBar::appendTab(const QPixmap &amp;pic, int id, const \
QString &amp;text)  ^~~~~~~~~</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kmultitabbar.cpp <span style="color: grey">(2327748)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125806/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7295262249973418086==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 