'Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-10-24 13:06:47
Message-ID: 20151024130647.11353.70614 () mimi ! kde ! org
[Download RAW message or body]

--===============7659839949953557776==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125760/#review87338
-----------------------------------------------------------

Ship it!

Ship It!

- Boudewijn Rempt

On Oct. 23, 2015, 5:28 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125760/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 5:28 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Allow icon themes to be embedded in applications and prefer the embedded ones, if \
> e.g. Krita or Kate ships an embedded theme, that shall be found and used. Qt does \
> already do so, by searching in :/icons. 
> 
> Diffs
> -----
> 
> autotests/CMakeLists.txt 707f39b 
> autotests/kiconloader_resourcethemetest.cpp PRE-CREATION 
> autotests/resources.qrc 5385977 
> src/kicontheme.cpp d0ab4b9 
> 
> Diff: https://git.reviewboard.kde.org/r/125760/diff/
> 
> 
> Testing
> -------
> 
> Themes still work, if you have the right theme in :/icons it is found, in contrast \
> to before this patch. Still a problem, that I need to takle in a different patch: \
> How to enforce the use of some theme, Qt is able to do so via setThemeName, \
> KIconLoader and Co. ignore that. 
> 
> Thanks,
> 
> Christoph Cullmann
> 
> 

--===============7659839949953557776==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125760/">https://git.reviewboard.kde.org/r/125760/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Boudewijn Rempt</p>

<br />
<p>On October 23rd, 2015, 5:28 p.m. UTC, Christoph Cullmann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt.</div>
<div>By Christoph Cullmann.</div>

<p style="color: grey;"><i>Updated Oct. 23, 2015, 5:28 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Allow icon themes to be embedded in applications and \
prefer the embedded ones, if e.g. Krita or Kate ships an embedded theme, that shall \
be found and used. Qt does already do so, by searching in :/icons.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Themes still work, if you have the right theme in \
:/icons it is found, in contrast to before this patch. Still a problem, that I need \
to takle in a different patch: How to enforce the use of some theme, Qt is able to do \
so via setThemeName, KIconLoader and Co. ignore that.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(707f39b)</span></li>

 <li>autotests/kiconloader_resourcethemetest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/resources.qrc <span style="color: grey">(5385977)</span></li>

 <li>src/kicontheme.cpp <span style="color: grey">(d0ab4b9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125760/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7659839949953557776==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 