[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125598: Allow KConfig to use resources as fallback config files
From: "Milian Wolff" <mail () milianw ! de>
Date: 2015-10-12 21:02:52
Message-ID: 20151012210252.1403.70826 () mimi ! kde ! org
[Download RAW message or body]
--===============8081976753408724274==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125598/#review86756
-----------------------------------------------------------
in principle, I'm cool with that change, but why do you need to ship a default file \
anyways?
KConfig is always used in the form
...read("value", default)
so the defaults are hardcoded there already. Why ship another default config file in \
ini format?
src/core/kconfig.cpp (line 720)
<https://git.reviewboard.kde.org/r/125598/#comment59690>
is prepending it really a fallback?
- Milian Wolff
On Oct. 12, 2015, 12:55 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125598/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 12:55 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> Like KXMLGui, KConfig has now a fallback to config files bundled with the \
> application in resources.
> Like kxmlgui, its in :/kconfig5.
>
> This allows e.g. KTextEditor deployment without any installed files beside the \
> library itself and should easy the shipping of default configs for non-linux/unix \
> platforms.
> Question is if :/kconfig5 is that nice a prefix, at least it is unique and matches \
> what we do with kxmlgui5.
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 8213bc4
> autotests/fallbackconfigresources.qrc PRE-CREATION
> autotests/fallbackconfigresourcestest.cpp PRE-CREATION
> src/core/kconfig.cpp 7f03869
>
> Diff: https://git.reviewboard.kde.org/r/125598/diff/
>
>
> Testing
> -------
>
> Added an unit test to show that the fallback resource is found and read.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
--===============8081976753408724274==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125598/">https://git.reviewboard.kde.org/r/125598/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in \
principle, I'm cool with that change, but why do you need to ship a default file \
anyways?</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KConfig is always used in the form</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%">...read("value", default) </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">so the defaults are hardcoded there already. Why ship \
another default config file in ini format?</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125598/diff/1/?file=410634#file410634line720" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/core/kconfig.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KConfigPrivate::parseConfigFiles()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">720</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">files</span><span class="p">.</span><span \
class="n">prepend</span><span class="p">(</span><span \
class="n">resourceFile</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is \
prepending it really a fallback?</p></pre> </div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On October 12th, 2015, 12:55 p.m. UTC, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2015, 12:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Like KXMLGui, KConfig has now a fallback to config \
files bundled with the application in resources.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Like \
kxmlgui, its in :/kconfig5.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This allows e.g. KTextEditor deployment \
without any installed files beside the library itself and should easy the shipping of \
default configs for non-linux/unix platforms.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Question is if :/kconfig5 is that nice a prefix, at least it is unique and \
matches what we do with kxmlgui5.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added an unit test to show that the fallback resource \
is found and read.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(8213bc4)</span></li>
<li>autotests/fallbackconfigresources.qrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/fallbackconfigresourcestest.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/core/kconfig.cpp <span style="color: grey">(7f03869)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125598/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8081976753408724274==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic