'Re: Review Request 125612: Make doctools optional'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: Review Request 125612: Make doctools optional
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2015-10-12 21:00:04
Message-ID: 20151012210004.1403.52478 () mimi ! kde ! org
[Download RAW message or body]

--===============1462878708312822626==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125612/#review86755
-----------------------------------------------------------

Ship it!

+1 from my side, seems like a nobrainer to me.

- Milian Wolff

On Oct. 12, 2015, 8:10 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125612/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Make doctools optional to avoid needing them just to deploy kservice on win/mac.
> 
> If this is OK for this framework, I would apply the same logic to others, too.
> 
> doctools is all nice, but just for getting the libraries built it is a bit heavy, \
> given nothing of its dependencies ships with Windows. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 90cd5c5 
> 
> Diff: https://git.reviewboard.kde.org/r/125612/diff/
> 
> 
> Testing
> -------
> 
> make install did still create docs if doctools is around
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
> 

--===============1462878708312822626==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125612/">https://git.reviewboard.kde.org/r/125612/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 \
from my side, seems like a nobrainer to me.</p></pre>  <br />

<p>- Milian Wolff</p>

<br />
<p>On October 12th, 2015, 8:10 p.m. UTC, Christoph Cullmann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, kdewin and David Faure.</div>
<div>By Christoph Cullmann.</div>

<p style="color: grey;"><i>Updated Oct. 12, 2015, 8:10 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Make doctools optional to avoid needing them just to \
deploy kservice on win/mac.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If this is OK for this framework, I \
would apply the same logic to others, too.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">doctools is all nice, \
but just for getting the libraries built it is a bit heavy, given nothing of its \
dependencies ships with Windows.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make install did still create docs if doctools is \
around</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(90cd5c5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125612/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1462878708312822626==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows

[prev in list] [next in list] [prev in thread] [next in thread] 