[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed
From: "Milian Wolff" <mail () milianw ! de>
Date: 2015-08-24 15:16:03
Message-ID: 20150824151603.4103.25472 () mimi ! kde ! org
[Download RAW message or body]
--===============7914974169695895086==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124902/#review84290
-----------------------------------------------------------
Ship it!
Ship It!
- Milian Wolff
On Aug. 24, 2015, 12:59 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124902/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 12:59 p.m.)
>
>
> Review request for KDE Frameworks and Kevin Funk.
>
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> There are usages of KGlobalAccel in e.g. KActionCollection of xmlgui
> framework which do not require a running kglobalaccel5. But due to the
> way KGlobalAccel inits, it always started the runtime part.
>
> This change ensures that kglobalaccel5 is only started once it's actually
> needed, by e.g. registering a global shortcut. If an application does
> not use global shortcuts the API should no longer trigger a start of the
> runtime part.
>
>
> Diffs
> -----
>
> src/kglobalaccel.cpp 3508c870c70a21e76263b7574c20b408cc09a837
> src/kglobalaccel_p.h a84f4038dac650ddb0fc1828e67e0851153b4456
>
> Diff: https://git.reviewboard.kde.org/r/124902/diff/
>
>
> Testing
> -------
>
> export $(dbus-launch)
> qdbusviewer &
> kate &
>
> -> kglobalaccel5 gets started
>
> with the change:
> kglobalaccel5 no longer gets started, when starting an application using global \
> shortcuts, it still gets started
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============7914974169695895086==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124902/">https://git.reviewboard.kde.org/r/124902/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Milian Wolff</p>
<br />
<p>On August 24th, 2015, 12:59 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Kevin Funk.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2015, 12:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There are usages of KGlobalAccel in e.g. KActionCollection of xmlgui \
framework which do not require a running kglobalaccel5. But due to the way \
KGlobalAccel inits, it always started the runtime part.
This change ensures that kglobalaccel5 is only started once it's actually
needed, by e.g. registering a global shortcut. If an application does
not use global shortcuts the API should no longer trigger a start of the
runtime part.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">export $(dbus-launch) qdbusviewer &
kate &</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">-> kglobalaccel5 gets started</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">with the change: kglobalaccel5 no longer gets started, when starting an \
application using global shortcuts, it still gets started</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kglobalaccel.cpp <span style="color: \
grey">(3508c870c70a21e76263b7574c20b408cc09a837)</span></li>
<li>src/kglobalaccel_p.h <span style="color: \
grey">(a84f4038dac650ddb0fc1828e67e0851153b4456)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124902/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7914974169695895086==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic