[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124896: Fix bad behavior / running OOM on Windows
From: "Milian Wolff" <mail () milianw ! de>
Date: 2015-08-24 8:53:20
Message-ID: 20150824085320.4103.94742 () mimi ! kde ! org
[Download RAW message or body]
--===============8464547518232967363==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124896/#review84255
-----------------------------------------------------------
Ship it!
and that really fixes the OOM issue? did that allocator put values in there that \
overflowed? anyhow, lgtm if it fixes the warnings alone
- Milian Wolff
On Aug. 24, 2015, 8:27 a.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124896/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 8:27 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 345860
> https://bugs.kde.org/show_bug.cgi?id=345860
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Fix bad behavior / running OOM on Windows
>
> When testing KDevelop on Windows we sometimes experienced excessive use
> of memory (> 2 gigs of RAM allocated). This patch appears to fix the
> issue.
>
> Compiler warnings didn't sound promising either:
> Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(129):
> warning C4319: '~': zero extending 'unsigned long' to 'quintptr' of greater size
> Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(206):
> warning C4319: '~': zero extending 'unsigned long' to 'quintptr' of greater size
> Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(256):
> warning C4267: '+=': conversion from 'size_t' to 'unsigned long', possible loss of \
> data
> BUG: 345860
>
>
> Diffs
> -----
>
> src/kzoneallocator.cpp 2ab9bb021ff09445f291f69ecc3f6facde7eed22
>
> Diff: https://git.reviewboard.kde.org/r/124896/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Funk
>
>
--===============8464547518232967363==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124896/">https://git.reviewboard.kde.org/r/124896/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
that really fixes the OOM issue? did that allocator put values in there that \
overflowed? anyhow, lgtm if it fixes the warnings alone</p></pre> <br />
<p>- Milian Wolff</p>
<br />
<p>On August 24th, 2015, 8:27 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2015, 8:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=345860">345860</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcompletion
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix bad behavior / running OOM on Windows</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%">When testing KDevelop on Windows we sometimes experienced \
excessive use of memory (> 2 gigs of RAM allocated). This patch appears to fix the
issue.
Compiler warnings didn't sound promising either:
Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(129):
warning C4319: '~': zero extending 'unsigned long' to \
'quintptr' of greater size \
Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(206): warning C4319: \
'~': zero extending 'unsigned long' to 'quintptr' of greater \
size Z:\kderoot\download\git\kcompletion\src\kzoneallocator.cpp(256):
warning C4267: '+=': conversion from 'size_t' to 'unsigned \
long', possible loss of data
BUG: 345860
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kzoneallocator.cpp <span style="color: \
grey">(2ab9bb021ff09445f291f69ecc3f6facde7eed22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124896/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8464547518232967363==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic