'Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from lo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from lo
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2015-08-20 16:37:47
Message-ID: 20150820163747.4320.21613 () mimi ! kde ! org
[Download RAW message or body]

--===============0503165206582921342==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84094
-----------------------------------------------------------

Ship it!

lgtm, but I don't like that kiconthemes_unittests_searchOnDisk is leaked :-/ nothing \
we can do about it, I assume?

- Milian Wolff

On Aug. 20, 2015, 8:07 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124811/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 8:07 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> This makes QIcon::fromTheme() much faster, for all cases where we have loaded the
> icon once before (including in another process).
> 
> 
> Diffs
> -----
> 
> autotests/kiconloader_unittest.cpp 6b60e7ebfc970c94ae865d56c4e33a8034b4fcee 
> src/kiconloader.cpp db3aa8f8fd6f8fb706edcb27cce073c36831934d 
> 
> Diff: https://git.reviewboard.kde.org/r/124811/diff/
> 
> 
> Testing
> -------
> 
> The unittest has a way to see if KIconLoader used the cache or searched on disk, \
> with the newly exported global int. I couldn't think of a better way. 
> I'll let Volker do the real-world testing and measure the overall impact as he did \
> previously. 
> 
> Thanks,
> 
> David Faure
> 
> 

--===============0503165206582921342==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124811/">https://git.reviewboard.kde.org/r/124811/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">lgtm, \
but I don't like that kiconthemes_unittests_searchOnDisk is leaked :-/ nothing we can \
do about it, I assume?</p></pre>  <br />

<p>- Milian Wolff</p>

<br />
<p>On August 20th, 2015, 8:07 a.m. UTC, David Faure wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By David Faure.</div>

<p style="color: grey;"><i>Updated Aug. 20, 2015, 8:07 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This makes QIcon::fromTheme() much faster, for all cases where we have \
loaded the icon once before (including in another process).</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The unittest has a way to see if KIconLoader used the \
cache or searched on disk, with the newly exported global int. I couldn't think of a \
better way.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'll let Volker do the real-world testing and measure \
the overall impact as he did previously.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kiconloader_unittest.cpp <span style="color: \
grey">(6b60e7ebfc970c94ae865d56c4e33a8034b4fcee)</span></li>

 <li>src/kiconloader.cpp <span style="color: \
grey">(db3aa8f8fd6f8fb706edcb27cce073c36831934d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124811/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0503165206582921342==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 