[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus sig
From: "Milian Wolff" <mail () milianw ! de>
Date: 2015-08-05 9:08:57
Message-ID: 20150805090857.11735.90220 () mimi ! kde ! org
[Download RAW message or body]
--===============2793828555993533327==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124607/#review83448
-----------------------------------------------------------
Ship it!
src/services/kservicegroup.cpp (line 680)
<https://git.reviewboard.kde.org/r/124607/#comment57672>
what about putting these calls into `KServiceGroupFactory::self()`? It seems to \
me that this would reduce the size of this patch considerable and makes sure it \
always works?
- Milian Wolff
On Aug. 5, 2015, 8:09 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124607/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 8:09 a.m.)
>
>
> Review request for KDE Frameworks and Vishesh Handa.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> This fixes threads without an event loop (e.g. in krunner) never noticing
> changes in ksycoca.
>
> Done-with: Vishesh Handa
>
>
> Diffs
> -----
>
> autotests/ksycocathreadtest.cpp 0d6ed4b89581fc506ea79c32c1de314637decf3e
> src/services/kmimetypetrader.cpp 655e5de9d272176e06af48a8417ea06e2412b9d8
> src/services/kplugininfo.cpp 56dc0b43036a2a49804ff799360c29c2121dda54
> src/services/kservice.cpp 3639a2875e5dbaefc6511d36d7b7f0fb7697ea74
> src/services/kservicegroup.cpp a2905da347877ccf34677776b63bd0eae518101f
> src/services/kservicetype.cpp 5e71351e5b7a0acef96104d8d14fa5b27817595d
> src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af
> src/sycoca/ksycoca.h 542029c7c21d495456065e51b485a26509152cd5
> src/sycoca/ksycoca.cpp 32d1689ad9cd01d3a8adb5123a1848278714ca95
> src/sycoca/ksycoca_p.h 393cfcf8f04c369ac9c03712d917c49112771838
>
> Diff: https://git.reviewboard.kde.org/r/124607/diff/
>
>
> Testing
> -------
>
> The improved unittest was failing with threadsWhoSawFakeService() always only 2 out \
> of 5 (the 2 threads with an event loop). Passes now.
>
> Thanks,
>
> David Faure
>
>
--===============2793828555993533327==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124607/">https://git.reviewboard.kde.org/r/124607/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124607/diff/2/?file=390245#file390245line680" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/services/kservicegroup.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QStringList KServiceGroup::layoutInfo() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">680</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KSycoca</span><span class="o">::</span><span class="n">self</span><span \
class="p">()</span><span class="o">-></span><span \
class="n">ensureCacheValid</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what \
about putting these calls into <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KServiceGroupFactory::self()</code>? It seems to me that this would reduce \
the size of this patch considerable and makes sure it always works?</p></pre> </div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On August 5th, 2015, 8:09 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Vishesh Handa.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2015, 8:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes threads without an event loop (e.g. in krunner) never \
noticing changes in ksycoca.
Done-with: Vishesh Handa</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The improved unittest was failing with \
threadsWhoSawFakeService() always only 2 out of 5 (the 2 threads with an event loop). \
Passes now.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/ksycocathreadtest.cpp <span style="color: \
grey">(0d6ed4b89581fc506ea79c32c1de314637decf3e)</span></li>
<li>src/services/kmimetypetrader.cpp <span style="color: \
grey">(655e5de9d272176e06af48a8417ea06e2412b9d8)</span></li>
<li>src/services/kplugininfo.cpp <span style="color: \
grey">(56dc0b43036a2a49804ff799360c29c2121dda54)</span></li>
<li>src/services/kservice.cpp <span style="color: \
grey">(3639a2875e5dbaefc6511d36d7b7f0fb7697ea74)</span></li>
<li>src/services/kservicegroup.cpp <span style="color: \
grey">(a2905da347877ccf34677776b63bd0eae518101f)</span></li>
<li>src/services/kservicetype.cpp <span style="color: \
grey">(5e71351e5b7a0acef96104d8d14fa5b27817595d)</span></li>
<li>src/services/kservicetypetrader.cpp <span style="color: \
grey">(290e44e9161c8db47278543714426fdd3b5a87af)</span></li>
<li>src/sycoca/ksycoca.h <span style="color: \
grey">(542029c7c21d495456065e51b485a26509152cd5)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: \
grey">(32d1689ad9cd01d3a8adb5123a1848278714ca95)</span></li>
<li>src/sycoca/ksycoca_p.h <span style="color: \
grey">(393cfcf8f04c369ac9c03712d917c49112771838)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124607/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2793828555993533327==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic