'Re: Review Request 124435: Remove temporary string allocations.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 124435: Remove temporary string allocations.
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2015-07-31 4:17:14
Message-ID: 20150731041714.31864.79165 () mimi ! kde ! org
[Download RAW message or body]

--===============6124501048433231238==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124435/
-----------------------------------------------------------

(Updated July 31, 2015, 4:17 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Christoph Feck.

Repository: kiconthemes

Description
-------

This removes approx. 5000 temporary allocations when starting up
kwrite. Found using heaptrack.

Diffs
-----

  src/kicontheme.cpp 652f3c7d9fae7a4ba6c174d112c97122cf7e7d44 

Diff: https://git.reviewboard.kde.org/r/124435/diff/

Testing
-------

Thanks,

Milian Wolff

--===============6124501048433231238==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124435/">https://git.reviewboard.kde.org/r/124435/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Milian Wolff.</div>

<p style="color: grey;"><i>Updated July 31, 2015, 4:17 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This removes approx. 5000 temporary allocations when starting up kwrite. \
Found using heaptrack.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kicontheme.cpp <span style="color: \
grey">(652f3c7d9fae7a4ba6c174d112c97122cf7e7d44)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124435/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6124501048433231238==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 