[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: kio and scheme://
From: Àlex_Fiestas <afiestas () kde ! org>
Date: 2015-02-17 22:32:02
Message-ID: CAJVyKoGhpHqAfgvRnx-gFkL=cXnpqhEK6=aotOSGNpLMj17raw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Review request to fix this!
https://git.reviewboard.kde.org/r/122613/
Thanks for the support guys!
On Sun, Nov 2, 2014 at 1:43 PM, =C3=80lex Fiestas <afiestas@kde.org> wrote:
> Hi there
>
> There are quite a few places where the following code is found:
>
> if (!url.path().endsWith('/')) {
> url.setPath(url.path() + '/');
> }
>
> Given an url like: 'scheme://' KUrl will return '/' as path while QUrl
> returns
> empty string.
>
> This is making kio add a third slash to the url in many places (because o=
f
> code like the one pasted before).
>
> As a result if you open dolphin and type smb://, it will be redirected to
> smb:///.
>
> Is this an intended behavior or should I start sending patches to prevent
> this
> from happening?
>
> Also, even though technically the path of 'smb://' is empty, users are
> used to
> that format (specially given how popular htp:// is) so I would like to ke=
ep
> supporting it.
>
> Cheers!
[Attachment #5 (text/html)]
<div dir="ltr">Review request to fix this!<div><a \
href="https://git.reviewboard.kde.org/r/122613/">https://git.reviewboard.kde.org/r/122613/</a><br></div><div><br></div><div>Thanks \
for the support guys!</div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Sun, Nov 2, 2014 at 1:43 PM, Àlex Fiestas <span \
dir="ltr"><<a href="mailto:afiestas@kde.org" \
target="_blank">afiestas@kde.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi there<br> <br>
There are quite a few places where the following code is found:<br>
<br>
if (!url.path().endsWith('/')) {<br>
url.setPath(url.path() + '/');<br>
}<br>
<br>
Given an url like: 'scheme://' KUrl will return '/' as path \
while QUrl returns<br> empty string.<br>
<br>
This is making kio add a third slash to the url in many places (because \
of<br> code like the one pasted before).<br>
<br>
As a result if you open dolphin and type smb://, it will be redirected \
to<br> smb:///.<br>
<br>
Is this an intended behavior or should I start sending patches to prevent \
this<br> from happening?<br>
<br>
Also, even though technically the path of 'smb://' is empty, users \
are used to<br> that format (specially given how popular htp:// is) so I \
would like to keep<br> supporting it.<br>
<br>
Cheers!</blockquote></div><br></div>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic