[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121090: Move kio-mtp to kio-extras
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-12-08 13:18:10
Message-ID: 20141208131810.5682.94610 () probe ! kde ! org
[Download RAW message or body]
--===============4495569571878167147==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121090/#review71545
-----------------------------------------------------------
Looks good. It's too much code for me to review properly; but as it's basically the \
same as the KDE4 version. +1.
mtp/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121090/#comment49902>
You're using i18n, but I don't see you set a translation domain anywhere.
mtp/README
<https://git.reviewboard.kde.org/r/121090/#comment49900>
This is all lies.
mtp/kio_mtp.cpp
<https://git.reviewboard.kde.org/r/121090/#comment49903>
who deletes this?
mtp/kio_mtp.cpp
<https://git.reviewboard.kde.org/r/121090/#comment49901>
this has _new_ in the functtion name, so I assume it allocates memory, if so who \
deletes it? It's not being done in this scope.
- David Edmundson
On Nov. 10, 2014, 9:30 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121090/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 9:30 a.m.)
>
>
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that \
> this kioslave should be with the rest and not alone somewhere without release. I \
> also formatted it a bit to follow kdelibs coding style.
> Discussion about this move can be found here \
> http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2
>
> Diffs
> -----
>
> mtp/kio_mtp_helpers.h PRE-CREATION
> mtp/kio_mtp_helpers.cpp PRE-CREATION
> mtp/mtp-network.desktop PRE-CREATION
> mtp/mtp.protocol PRE-CREATION
> mtp/solid_mtp.desktop PRE-CREATION
> mtp/filecache.cpp PRE-CREATION
> mtp/kio-mtp.kdev4 PRE-CREATION
> mtp/kio_mtp.h PRE-CREATION
> mtp/kio_mtp.cpp PRE-CREATION
> CMakeLists.txt 8f82688
> mtp/CMakeLists.txt PRE-CREATION
> mtp/COPYING PRE-CREATION
> mtp/LICENCE PRE-CREATION
> mtp/Messages.sh PRE-CREATION
> mtp/README PRE-CREATION
> mtp/devicecache.h PRE-CREATION
> mtp/devicecache.cpp PRE-CREATION
> mtp/filecache.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121090/diff/
>
>
> Testing
> -------
>
> I have tested copying files, creating and removing folders in Dolphin with my Nexus \
> 4 and everything seems to work fine.
>
> Thanks,
>
> Jan Grulich
>
>
--===============4495569571878167147==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121090/">https://git.reviewboard.kde.org/r/121090/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good. It's too much code for me to review properly; but as it's basically the same as \
the KDE4 version. +1.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121090/diff/1/?file=327540#file327540line9" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mtp/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">9</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">You're using i18n, but I don't see you set a translation domain \
anywhere.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121090/diff/1/?file=327544#file327544line20" \
style="color: black; font-weight: bold; text-decoration: underline;">mtp/README</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">20</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">2) Clone from \
git://anongit.kde.org/kio-mtp</pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is all lies.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121090/diff/1/?file=327551#file327551line70" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mtp/kio_mtp.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">70</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">deviceCache</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">DeviceCache</span><span class="p">(</span><span \
class="mi">60000</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">who \
deletes this?</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121090/diff/1/?file=327551#file327551line657" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mtp/kio_mtp.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">657</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">LIBMTP_file_t</span> <span class="o">*</span><span class="n">file</span> \
<span class="o">=</span> <span class="n">LIBMTP_new_file_t</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
has <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">new</em> in the functtion name, so I assume it \
allocates memory, if so who deletes it? It's not being done in this scope.</p></pre> \
</div> </div>
<br />
<p>- David Edmundson</p>
<br />
<p>On November 10th, 2014, 9:30 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Philipp Schmidt.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2014, 9:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch moves kio-mtp from its frameworks branch to \
kio-extras. I believe that this kioslave should be with the rest and not alone \
somewhere without release. I also formatted it a bit to follow kdelibs coding \
style.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Discussion about this move can be found here \
http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have tested copying files, creating and removing \
folders in Dolphin with my Nexus 4 and everything seems to work fine.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mtp/kio_mtp_helpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp_helpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/mtp-network.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/mtp.protocol <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/solid_mtp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/filecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio-mtp.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8f82688)</span></li>
<li>mtp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/COPYING <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/LICENCE <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/devicecache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/devicecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/filecache.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121090/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4495569571878167147==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic