[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119773: Launch scripts in autostart-directories
From: Martin Yrjölä <martin.yrjola () gmail ! com>
Date: 2014-08-19 7:45:02
Message-ID: 20140819074502.26013.71834 () probe ! kde ! org
[Download RAW message or body]
--===============1527794354616580524==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119773/
-----------------------------------------------------------
(Updated Aug. 19, 2014, 7:45 a.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks.
Bugs: 335878 and 338242
https://bugs.kde.org/show_bug.cgi?id=335878
https://bugs.kde.org/show_bug.cgi?id=338242
Repository: kinit
Description
-------
This fixes execution of scripts other than ".desktop"-files in the \
~/.config/autostart directory when starting a session. This functionality was removed \
in https://git.reviewboard.kde.org/r/118977/ because of \
https://bugs.kde.org/show_bug.cgi?id=335878.
Things that still have to be discussed:
* Is kinit the right place for this functionality? I think it makes sense because all \
other autostart functionality is there.
* Is kioclient5 the correct way to start the scripts?
* Which kind of files in autostart-directories gets executed?
* I chose a simple *.sh regex for testing purposes.
* In KSMServer and KDE4 only obvious backup files (*.bak, *~, %*% etc.) were \
excluded.
Diffs
-----
src/klauncher/autostart.cpp 0706c735c3caf1c010d9968337456bfc5a0805c1
Diff: https://git.reviewboard.kde.org/r/119773/diff/
Testing
-------
Works for scripts that exit and those that run the whole session. Now the only \
limitation is the *.sh wildcard.
Thanks,
Martin Yrjölä
--===============1527794354616580524==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119773/">https://git.reviewboard.kde.org/r/119773/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Yrjölä.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2014, 7:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335878">335878</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=338242">338242</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes execution of scripts other than \
".desktop"-files in the ~/.config/autostart directory when starting a session. This \
functionality was removed in https://git.reviewboard.kde.org/r/118977/ because of \
https://bugs.kde.org/show_bug.cgi?id=335878.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Things that still have \
to be discussed:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> Is kinit the right \
place for this functionality? I think it makes sense because all other autostart \
functionality is there.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> </em> Is kioclient5 the correct way \
to start the scripts?<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> Which kind of files in \
autostart-directories gets executed?<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
* I chose a simple </em>.sh regex for testing purposes.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
* In KSMServer and KDE4 only obvious backup files (*.bak, *~, %*% etc.) were \
excluded.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works for scripts that exit and those that run the \
whole session. Now the only limitation is the *.sh wildcard.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klauncher/autostart.cpp <span style="color: \
grey">(0706c735c3caf1c010d9968337456bfc5a0805c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119773/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1527794354616580524==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic