[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119512: Fix saving/loading of file dialog sizes
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2014-08-02 22:24:17
Message-ID: 20140802222417.17766.25790 () probe ! kde ! org
[Download RAW message or body]
--===============1666889982675131349==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
On July 28, 2014, 10:17 a.m., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by calling \
> > ::winId(), then restore the size and ultimately ::exec()
> > Otherwise you could open an own nested eventloop instead of relying on the \
> > dialogs exec, but that'd be less elegant.
> > In either case I don't see why bringing your own config re/storage.
>
> Lukáš Tinkl wrote:
> The trick with winId() unfortunately doesn't work, the dialog gets restored to the \
> default size, not the saved one... :/ Any other ideas?
> Thomas Lübking wrote:
> I'm not gonna say "impossible", but the reason could then not be the absence of a \
> windowHandle() Eventually sth. alters the window size post the restore.
>
> Have you checked for presence of a m_dialog->windowHandle() after calling \
> m_dialog->winId() and m_dialog->size() after calling \
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), \
> conf->group("FileDialogSize")); and before calling m_dialog->exec() ?
> Martin Klapetek wrote:
> KWindowConfig::restoreWindowSize is broken for some reason.
>
> I did some investigation and basically what happens is this:
> - KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry call
> - geometry is set to the QWindow, but no to its QWidgets (no idea why)
> - when event loop hits next loop, widgets are checked if their size >= their min \
> size
> - because they didn't receive the updated geometry, this^ is not true
> - the widgets get resized to their min size
> - the window has a wrong geometry
>
> I don't know why the widgets don't receive the event however, my knowledge in this \
> is lacking.
> Lukáš Tinkl wrote:
> So how do we proceed with this one? Having tiny filedialogs is annoying as hell...
>
> Thomas Lübking wrote:
> Fix KWindowConfig::restoreWindowSize, I'd say.
> I assume calling
>
> + window->create();
>
> before "window->resize(width, height);" in \
> frameworks/kconfig/src/gui/kwindowconfig.cpp:81 should be be sufficient? (This \
> should ensure d->platformWindow->setGeometry(QRect(position(), newSize)); is called \
> in QWindow::resize())
> Lukáš Tinkl wrote:
> Nope, it didn't work unfortunately :/
>
> Thomas Lübking wrote:
> You must still ensure that there's a QWindow before the Dialog::exec() call, ie. \
> calling ::winId() is still required in addition on this particular case.
> Lukáš Tinkl wrote:
> Done that, didn't help
>
> Thomas Lübking wrote:
> What's your testcase on this?
>
> QFileDialog *dlg = new QFileDialog;
> dlg->setFileMode(QFileDialog::Directory);
> dlg->setOption(QFileDialog::ShowDirsOnly);
> dlg->exec();
>
> gets me a ::windowHandle() before, but *does* get me one after.
>
> If I then call
> KSharedConfig::Ptr conf = KSharedConfig::openConfig();
> KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), \
> conf->group("FileDialogSize"));
> and from there
> window->create();
> right after the
>
> if (!window) {
> return;
> }
>
> check, I'm "sorry" to say, but the dialog size now _is_ restored for me.
>
>
> --------------
> What rather seems a problem is that the size does not get stored when eg. closing \
> the dialog via the titlebar "close" button. I've to say cancel or ok.
>
> Lukáš Tinkl wrote:
> Yup, it works with a plain Q(File)Dialog, what doesn't work here is the wrapper due \
> to the abstraction layer in QPA imo
> Thomas Lübking wrote:
> Humm? QFileDialog of course invokes the platformtheme if XDG_CURRENT_DESKTOP is set \
> to KDE.
> 1. I could trace the invocation (strace/qDebug())
> 2. I get a "better" filedialog as compared to an unset (or different, the Gtk+ \
> thing sucks ;-) environment
> With mentioned changes it /does/ work here using \
> /usr/lib/qt/plugins/platformthemes/KDEPlatformTheme.so, ie. this wrapper.
> I'll add two RRs for it.
>
> Lukáš Tinkl wrote:
> Great, thanks
>
> Thomas Lübking wrote:
> In case you wonder: I could not create a new request in the past 5h, RB does not \
> respond on the link. I'll link them here as soon as RB woke up.
Please report any faults in KDE infrastructure to Sysadmin through our usual channels \
- I have restarted Reviewboard, which will hopefully resolve the issue.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
-----------------------------------------------------------
On July 28, 2014, 10:21 a.m., Lukáš Tinkl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 10:21 a.m.)
>
>
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin \
> Klapetek.
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> This patch tries to fix saving/restoring file dialog sizes. Using \
> KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() methods. \
> Instead, the patch uses the same method as KDirSelectDialog.
>
> Diffs
> -----
>
> src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1
> src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5
> src/platformtheme/kdirselectdialog.cpp 9a4082a
> src/platformtheme/kdirselectdialog_p.h 5a8e758
>
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
>
>
> Testing
> -------
>
> Current Plasma 5, working fine :)
>
>
> Thanks,
>
> Lukáš Tinkl
>
>
--===============1666889982675131349==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119512/">https://git.reviewboard.kde.org/r/119512/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2014, 10:17 a.m. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If the only issue is the open ::exec() TODO, you might \
"trick" it by calling ::winId(), then restore the size and ultimately ::exec()</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Otherwise you could open an own nested eventloop instead of relying on the \
dialogs exec, but that'd be less elegant.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In either case I don't \
see why bringing your own config re/storage.</p></pre> </blockquote>
<p>On July 28th, 2014, 11:53 a.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
trick with winId() unfortunately doesn't work, the dialog gets restored to the \
default size, not the saved one... :/ Any other ideas?</p></pre> </blockquote>
<p>On July 28th, 2014, 12:58 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not gonna say "impossible", but the reason could then not be the absence of a \
windowHandle()<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Eventually sth. alters the window size post the \
restore.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Have you checked for presence of a \
m_dialog->windowHandle() after calling m_dialog->winId() and \
m_dialog->size() after calling <br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), \
conf->group("FileDialogSize")); and before calling m_dialog->exec() ?</p></pre> \
</blockquote>
<p>On July 28th, 2014, 1:07 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KWindowConfig::restoreWindowSize is broken for some reason.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I did some investigation and basically what happens is this:<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- KWindowConfig::restoreWindowSize resutls in QXcbWindow::setGeometry call<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- geometry is set to the QWindow, but no to its QWidgets (no idea why)<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- when event loop hits next loop, widgets are checked if their size >= their min \
size<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
- because they didn't receive the updated geometry, this^ is not true<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
- the widgets get resized to their min size<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
- the window has a wrong geometry</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't know why the widgets don't receive the event \
however, my knowledge in this is lacking.</p></pre> </blockquote>
<p>On July 31st, 2014, 8:50 p.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So \
how do we proceed with this one? Having tiny filedialogs is annoying as \
hell...</p></pre> </blockquote>
<p>On July 31st, 2014, 9:10 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix \
KWindowConfig::restoreWindowSize, I'd say.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> I assume calling</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">window->create();</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">before "window->resize(width, height);" in \
frameworks/kconfig/src/gui/kwindowconfig.cpp:81 should be be sufficient?<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> (This should ensure \
d->platformWindow->setGeometry(QRect(position(), newSize)); is called in \
QWindow::resize())</p></pre> </blockquote>
<p>On July 31st, 2014, 9:34 p.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nope, \
it didn't work unfortunately :/</p></pre> </blockquote>
<p>On August 1st, 2014, 10:10 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
must still ensure that there's a QWindow before the Dialog::exec() call, ie. calling \
::winId() is still required in addition on this particular case.</p></pre> \
</blockquote>
<p>On August 1st, 2014, 10:31 a.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Done \
that, didn't help</p></pre> </blockquote>
<p>On August 1st, 2014, 8:32 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What's your testcase on this?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">QFileDialog *dlg = new \
QFileDialog;<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> dlg->setFileMode(QFileDialog::Directory);<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> dlg->setOption(QFileDialog::ShowDirsOnly);<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
dlg->exec();</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">gets me a ::windowHandle() before, but \
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">does</em> get me one after.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I \
then call<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> KSharedConfig::Ptr conf = \
KSharedConfig::openConfig();<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> \
KWindowConfig::restoreWindowSize(m_dialog->windowHandle(), \
conf->group("FileDialogSize"));</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">and from there <br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> window->create();<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> right after the</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if (!window) {<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> return;<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> }</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">check, I'm "sorry" to say, but the dialog size now <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">is</em> restored for me.</p> <hr style="text-rendering: inherit;margin: \
0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What rather seems a problem is that the size does not get stored when eg. \
closing the dialog via the titlebar "close" button.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
I've to say cancel or ok.</p></pre> </blockquote>
<p>On August 2nd, 2014, 8:47 a.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yup, \
it works with a plain Q(File)Dialog, what doesn't work here is the wrapper due to the \
abstraction layer in QPA imo</p></pre> </blockquote>
<p>On August 2nd, 2014, 10:04 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Humm? \
QFileDialog of course invokes the platformtheme if XDG_CURRENT_DESKTOP is set to \
KDE.</p> <ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">I could trace the invocation \
(strace/qDebug())</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">I get a "better" filedialog as compared \
to an unset (or different, the Gtk+ thing sucks ;-) environment</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With mentioned changes it /does/ work here using \
/usr/lib/qt/plugins/platformthemes/KDEPlatformTheme.so, ie. this wrapper.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'll add two RRs for it.</p></pre> </blockquote>
<p>On August 2nd, 2014, 10:06 a.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Great, thanks</p></pre> </blockquote>
<p>On August 2nd, 2014, 3:26 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
case you wonder: I could not create a new request in the past 5h, RB does not respond \
on the link.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> I'll link them here as soon as RB woke up.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please report any faults in KDE infrastructure to Sysadmin through our \
usual channels - I have restarted Reviewboard, which will hopefully resolve the \
issue.</p></pre> <br />
<p>- Ben</p>
<br />
<p>On July 28th, 2014, 10:21 a.m. UTC, Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin \
Klapetek.</div> <div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated July 28, 2014, 10:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch tries to fix saving/restoring file dialog \
sizes. Using KWindowConfig::restoreWindowSize() doesn't work here with the modal \
exec() methods. Instead, the patch uses the same method as KDirSelectDialog. \
</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Current Plasma 5, working fine :)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/kdeplatformfiledialoghelper.h <span style="color: \
grey">(406a4f1)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: \
grey">(520b6f5)</span></li>
<li>src/platformtheme/kdirselectdialog.cpp <span style="color: \
grey">(9a4082a)</span></li>
<li>src/platformtheme/kdirselectdialog_p.h <span style="color: \
grey">(5a8e758)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119512/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1666889982675131349==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic