'Re: Review Request 118906: Fix dialog's check for isTooltip'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 118906: Fix dialog's check for isTooltip
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2014-06-24 18:25:55
Message-ID: 20140624182555.24601.18944 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118906/#review60910
-----------------------------------------------------------

Ship it!

Ship It!

- Aleix Pol Gonzalez

On June 23, 2014, 5:26 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118906/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 5:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Fix dialog's check for isTooltip
> 
> Qt::Tooltip is a mix of other flags (0x0001101)
> 
> using a simple & is not correct as any Window will have (0x0000001) set
> and the bitwise & operation will return a non-zero value
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp ab56ccc 
> 
> Diff: https://git.reviewboard.kde.org/r/118906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118906/">https://git.reviewboard.kde.org/r/118906/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On June 23rd, 2014, 5:26 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated June 23, 2014, 5:26 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix dialog&#39;s check for isTooltip

Qt::Tooltip is a mix of other flags (0x0001101)

using a simple &amp; is not correct as any Window will have (0x0000001) set
and the bitwise &amp; operation will return a non-zero value

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasmaquick/dialog.cpp <span style="color: grey">(ab56ccc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118906/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 