'Re: Review Request 117602: Remove more UPnP stuff'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 117602: Remove more UPnP stuff
From:       "Commit Hook" <null () kde ! org>
Date:       2014-04-25 15:03:36
Message-ID: 20140425150336.15116.71665 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117602/#review56538
-----------------------------------------------------------

This review has been submitted with commit ff9ff7fffb4cb976cce4bf27e2ccf527d26a366a \
by Michael Palimaka to branch master.

- Commit Hook

On April 16, 2014, 7:46 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117602/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 7:46 p.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> Since the UPnP backend was removed, it looks like this other UPnP stuff can go too.
> 
> 
> Diffs
> -----
> 
> KF5SolidConfig.cmake.in a767f1963816a1f706ee6a4871f0ba95745b7151 
> cmake/FindHUpnp.cmake 8b34c2e8279c0cf21f2703e1cd5b22c3c35891dc 
> src/solid/backends/fstab/fstabdevice.h cd8d92622ae35230cf9e90422a68260c1bab1bdb 
> src/solid/config-solid.h.cmake 84d12604e0177d5af7108daf11b9b99be33468d5 
> src/solid/managerbase.cpp 66338125df7eb58fefb31c423b37258b9b96f1da 
> src/solid/networkshare.h 6d8ab1e914d0f2fc570a48b4959aed99f3859c15 
> 
> Diff: https://git.reviewboard.kde.org/r/117602/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117602/">https://git.reviewboard.kde.org/r/117602/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ff9ff7fffb4cb976cce4bf27e2ccf527d26a366a by Michael Palimaka to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On April 16th, 2014, 7:46 p.m. UTC, Michael Palimaka wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Àlex Fiestas.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated April 16, 2014, 7:46 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since the UPnP backend was removed, it looks like this other UPnP stuff \
can go too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds, tests pass.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KF5SolidConfig.cmake.in <span style="color: \
grey">(a767f1963816a1f706ee6a4871f0ba95745b7151)</span></li>

 <li>cmake/FindHUpnp.cmake <span style="color: \
grey">(8b34c2e8279c0cf21f2703e1cd5b22c3c35891dc)</span></li>

 <li>src/solid/backends/fstab/fstabdevice.h <span style="color: \
grey">(cd8d92622ae35230cf9e90422a68260c1bab1bdb)</span></li>

 <li>src/solid/config-solid.h.cmake <span style="color: \
grey">(84d12604e0177d5af7108daf11b9b99be33468d5)</span></li>

 <li>src/solid/managerbase.cpp <span style="color: \
grey">(66338125df7eb58fefb31c423b37258b9b96f1da)</span></li>

 <li>src/solid/networkshare.h <span style="color: \
grey">(6d8ab1e914d0f2fc570a48b4959aed99f3859c15)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117602/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 