[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117333: Remove Solid::Networking usage from KIO
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-04-11 9:37:30
Message-ID: 20140411093730.5498.89715 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117333/#review55435
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On April 10, 2014, 12:08 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117333/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 12:08 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Replace usage of Solid::Networking with QNetworkConfigurationManager which does everything we want.
>
>
> Diffs
> -----
>
> src/filewidgets/kstatusbarofflineindicator.h 0210eb0
> src/filewidgets/kstatusbarofflineindicator.cpp b19e42c
> src/ioslaves/http/http.h 2a29a15
> src/ioslaves/http/http.cpp de1a1dd
> src/kpac/CMakeLists.txt 97bb6b6
> src/kpac/config-kpac.h.cmake 440d082
> src/kpac/proxyscout.h 3338587
> src/kpac/proxyscout.cpp 9574d94
>
> Diff: https://git.reviewboard.kde.org/r/117333/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117333/">https://git.reviewboard.kde.org/r/117333/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Kevin Ottens</p>
<br />
<p>On April 10th, 2014, 12:08 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated April 10, 2014, 12:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replace usage of Solid::Networking with QNetworkConfigurationManager \
which does everything we want.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/filewidgets/kstatusbarofflineindicator.h <span style="color: \
grey">(0210eb0)</span></li>
<li>src/filewidgets/kstatusbarofflineindicator.cpp <span style="color: \
grey">(b19e42c)</span></li>
<li>src/ioslaves/http/http.h <span style="color: grey">(2a29a15)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(de1a1dd)</span></li>
<li>src/kpac/CMakeLists.txt <span style="color: grey">(97bb6b6)</span></li>
<li>src/kpac/config-kpac.h.cmake <span style="color: grey">(440d082)</span></li>
<li>src/kpac/proxyscout.h <span style="color: grey">(3338587)</span></li>
<li>src/kpac/proxyscout.cpp <span style="color: grey">(9574d94)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117333/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic