[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Review Request 117435: Import KDirSelectDialog + use it if QFileDialog requests dirs only
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2014-04-08 11:58:30
Message-ID: 20140408115830.26935.41348 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117435/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: frameworkintegration
Description
-------
This imports KDirSelectDialog from kde4support into frameworksintegration (+ \
KFileTreeView) and uses the dir select dialog in case the user wants to select a \
directory.
To not disturb the current code too much, I've created a new class \
KDEPlatformFileDialogBase, made KDEPlatformFileDialog derive from that as well as \
KDirSelectDialog, and then KDEPlatformFileDialogHelper stores the \
KDEPlatformFileDialogBase pointer, which is either the file selector or dialog \
selector, but with the same API. The API is just added to KDirSelectDialog and it \
calls its own functions internally.
Diffs
-----
autotests/CMakeLists.txt 8611b29
src/platformtheme/CMakeLists.txt e9a2454
src/platformtheme/kdeplatformfiledialogbase_p.h PRE-CREATION
src/platformtheme/kdeplatformfiledialoghelper.h 4621071
src/platformtheme/kdeplatformfiledialoghelper.cpp c834703
src/platformtheme/kdirselectdialog/kdirselectdialog.h PRE-CREATION
src/platformtheme/kdirselectdialog/kdirselectdialog.cpp PRE-CREATION
src/platformtheme/kdirselectdialog/kfiletreeview.cpp PRE-CREATION
src/platformtheme/kdirselectdialog/kfiletreeview_p.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/117435/diff/
Testing
-------
The testing app in tests/ works exactly as expected; all autotests pass.
Thanks,
Martin Klapetek
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117435/">https://git.reviewboard.kde.org/r/117435/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This imports KDirSelectDialog from kde4support into \
frameworksintegration (+ KFileTreeView) and uses the dir select dialog in case the \
user wants to select a directory.
To not disturb the current code too much, I've created a new class \
KDEPlatformFileDialogBase, made KDEPlatformFileDialog derive from that as well as \
KDirSelectDialog, and then KDEPlatformFileDialogHelper stores the \
KDEPlatformFileDialogBase pointer, which is either the file selector or dialog \
selector, but with the same API. The API is just added to KDirSelectDialog and it \
calls its own functions internally.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The testing app in tests/ works exactly as expected; all autotests \
pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(8611b29)</span></li>
<li>src/platformtheme/CMakeLists.txt <span style="color: grey">(e9a2454)</span></li>
<li>src/platformtheme/kdeplatformfiledialogbase_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.h <span style="color: \
grey">(4621071)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: \
grey">(c834703)</span></li>
<li>src/platformtheme/kdirselectdialog/kdirselectdialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdirselectdialog/kdirselectdialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdirselectdialog/kfiletreeview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdirselectdialog/kfiletreeview_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117435/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic