[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Fix frameworksintegration tests
From:       Àlex Fiestas <afiestas () kde ! org>
Date:       2013-12-19 11:53:13
Message-ID: 13110622.iCzLxqgQgq () monsterbad
[Download RAW message or body]

On Thursday 19 December 2013 00:20:25 Alex Merry wrote:
> Fix the kdeplatformplugin_unittest, which fails on Jenkins.
> 
> The old code would attempt to cast a QVariant containing a QStringList
> to a QString, and check it was empty.  This value was never meant to be
> empty, but the test happened to succeed most of the time, because the
> case fails for multiple-element stringlists (returning an empty string).
>  This is not the case on Jenkins, however.
> 
> Attached patch does something a bit saner.
> 
> Alex

Ship it!
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]