[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D14191: puzzle(sudoku), prevent score overriding.
From:       Aman Kumar Gupta <noreply () phabricator ! kde ! org>
Date:       2018-07-25 11:46:30
Message-ID: 83166b77da8e5b614735341d0be11bfa () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

amankumargupta requested changes to this revision.
amankumargupta added a comment.
This revision now requires changes to proceed.


  There's still slight overriding: https://pasteboard.co/Hw5hzi5.png
  
  Let's assume, rem = space left between grid's bottom and bar's top. I'm leaving it \
to you to figure out the exact expression from the code ;)  Then can you do something \
like, height: Math.min(defaultHeight, rem) for the score?  It should resolve this.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D14191

To: ganeshredcobra, #gcompris, amankumargupta
Cc: amankumargupta, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, \
rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin


[Attachment #3 (text/html)]

<table><tr><td style="">amankumargupta requested changes to this revision.<br \
/>amankumargupta added a comment.<br />This revision now requires changes to proceed. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14191">View Revision</a></tr></table><br \
/><div><div><p>There&#039;s still slight overriding: <a \
href="https://pasteboard.co/Hw5hzi5.png" class="remarkup-link" target="_blank" \
rel="noreferrer">https://pasteboard.co/Hw5hzi5.png</a></p>

<p>Let&#039;s assume, rem = space left between grid&#039;s bottom and bar&#039;s top. \
I&#039;m leaving it to you to figure out the exact expression from the code ;)<br /> \
Then can you do something like, height: Math.min(defaultHeight, rem) for the \
score?<br /> It should resolve this.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14191">https://phabricator.kde.org/D14191</a></div></div><br \
/><div><strong>To: </strong>ganeshredcobra, GCompris, amankumargupta<br /><strong>Cc: \
</strong>amankumargupta, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, \
echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, \
bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]