[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 126306: Fix errror with 'break' statement out of context in PHP 7
From: "Filipe Saraiva" <filipe () kde ! org>
Date: 2015-12-12 13:44:08
Message-ID: 20151212134408.3920.14310 () mimi ! kde ! org
[Download RAW message or body]
--===============4224769984345966873==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126306/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 1:44 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu and Andreas Cord-Landwehr.
Changes
-------
Submitted with commit 6ae6c6679af184270a5a1bc16dc341746f850d10 by Albert Astals Cid \
on behalf of Filipe Saraiva to branch master.
Repository: edu-kde-org
Description
-------
PHP 7 introduces an error when `break` is utilized out of `switch` or `loop` context. \
The patch fixes this error.
Diffs
-----
site_includes/class_submenu.inc 790e1a2
Diff: https://git.reviewboard.kde.org/r/126306/diff/
Testing
-------
If I run the current code in an Apache server with PHP 7, I get the follow error:
```[Thu Dec 10 16:21:36 2015] PHP Fatal error: 'break' not in the 'loop' or 'switch' \
context in /home/kdevil/kdesrc/websites/edu-kde-org/site_includes/class_submenu.inc \
on line 31``` ```[Thu Dec 10 16:21:36 2015] 127.0.0.1:55496 [500]: / - 'break' not in \
the 'loop' or 'switch' context in \
/home/kdevil/kdesrc/websites/edu-kde-org/site_includes/class_submenu.inc on line \
31```
After the fix, I could to run the website correctly.
Thanks,
Filipe Saraiva
--===============4224769984345966873==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126306/">https://git.reviewboard.kde.org/r/126306/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2015, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 6ae6c6679af184270a5a1bc16dc341746f850d10 by Albert \
Astals Cid on behalf of Filipe Saraiva to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
edu-kde-org
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">PHP 7 introduces an error when <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">break</code> is utilized out of <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">switch</code> or <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">loop</code> \
context. The patch fixes this error.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If I run the current code in an Apache server with PHP \
7, I get the follow error:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;"><code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">[Thu Dec 10 16:21:36 2015] PHP Fatal error: 'break' not in the 'loop' or \
'switch' context in /home/kdevil/kdesrc/websites/edu-kde-org/site_includes/class_submenu.inc \
on line 31</code> <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">[Thu Dec 10 16:21:36 2015] \
127.0.0.1:55496 [500]: / - 'break' not in the 'loop' or 'switch' context in \
/home/kdevil/kdesrc/websites/edu-kde-org/site_includes/class_submenu.inc on line \
31</code></p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After the fix, I could to run the website \
correctly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>site_includes/class_submenu.inc <span style="color: grey">(790e1a2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126306/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4224769984345966873==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic