[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 124849: Don't use "apps" directory when installing kvtml data
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2015-08-26 22:04:10
Message-ID: 20150826220410.4103.97276 () mimi ! kde ! org
[Download RAW message or body]
--===============1901371571274688161==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 20, 2015, 3:59 p.m., Jeremy Whiting wrote:
> > Yes, we did that so both libkdeedu using (Qt4/kdelibs based khangman) and \
> > libkeduvocdocument (kanagram, kwordquiz) used the apps/kvtml path, but all \
> > applications have been ported by now. Though I do wonder if it wouldn't be easier \
> > to just make knewstuff download to share/apps/kvtml instead of share/kvtml so \
> > anyone with existing data from a libkdeedu install can keep using those files.
>
> Heiko Becker wrote:
> I didn't know about the first part. It seems a bit weird to me to use an outdated \
> location in a new tool, though. Perhaps it would be possible to move already \
> downloaded data with the help of an extended version of Kdelibs4ConfigMigrator?
Possibly. For now I think we should just stick to how it worked in the past. What \
problem are these changes trying to fix? KNewStuff downloading files to the wrong \
place ? (or a place that kanagram doesn't see them)?
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124849/#review84119
-----------------------------------------------------------
On Aug. 20, 2015, 2:50 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124849/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 2:50 p.m.)
>
>
> Review request for KDE Edu and Jeremy Whiting.
>
>
> Repository: kdeedu-data
>
>
> Description
> -------
>
> It shouldn't be used anymore because of the transition from from
> KStandardDirs to QStandardPaths, according to
> https://mail.kde.org/pipermail/kde-frameworks-devel/2013-November/008086.html
>
>
> Diffs
> -----
>
> data/kvtml/CMakeLists.txt 905f1c5
>
> Diff: https://git.reviewboard.kde.org/r/124849/diff/
>
>
> Testing
> -------
>
> Vocabularies installed by kdeedu-data now show up in kanagram.
>
>
> Thanks,
>
> Heiko Becker
>
>
--===============1901371571274688161==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124849/">https://git.reviewboard.kde.org/r/124849/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 20th, 2015, 3:59 p.m. MDT, <b>Jeremy \
Whiting</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes, we did that so both libkdeedu using (Qt4/kdelibs \
based khangman) and libkeduvocdocument (kanagram, kwordquiz) used the apps/kvtml \
path, but all applications have been ported by now. Though I do wonder if it wouldn't \
be easier to just make knewstuff download to share/apps/kvtml instead of share/kvtml \
so anyone with existing data from a libkdeedu install can keep using those \
files.</p></pre> </blockquote>
<p>On August 20th, 2015, 4:18 p.m. MDT, <b>Heiko Becker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't know about \
the first part. It seems a bit weird to me to use an outdated location in a new tool, \
though. Perhaps it would be possible to move already downloaded data with the help of \
an extended version of Kdelibs4ConfigMigrator?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Possibly. For now I think we should just stick to how it worked in the \
past. What problem are these changes trying to fix? KNewStuff downloading files to \
the wrong place ? (or a place that kanagram doesn't see them)?</p></pre> <br />
<p>- Jeremy</p>
<br />
<p>On August 20th, 2015, 2:50 p.m. MDT, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Jeremy Whiting.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2015, 2:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeedu-data
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It shouldn't be used anymore because of the transition \
from from KStandardDirs to QStandardPaths, according to
https://mail.kde.org/pipermail/kde-frameworks-devel/2013-November/008086.html</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Vocabularies installed by kdeedu-data now show up in kanagram.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/kvtml/CMakeLists.txt <span style="color: grey">(905f1c5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124849/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1901371571274688161==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic