[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 122877: Move Parley's editor model classes into libkeduvocdocument
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2015-05-29 13:43:44
Message-ID: 20150529134344.31615.46432 () mimi ! kde ! org
[Download RAW message or body]
--===============3631424519479868249==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 9, 2015, 2:59 p.m., Inge Wallin wrote:
> > keduvocdocument/keduvocvocabularymodel.cpp, lines 215-224
> > <https://git.reviewboard.kde.org/r/122877/diff/1/?file=353919#file353919line215>
> >
> > A tooltip sounds like something that belongs in an application rather than in a \
> > library. This should probably be in Parley instead of here. Check if it's \
> > possible to move or if it really needs to be here.
> > Also check if there are more tooltips in other models.
Nope. Tooltips text come from the model in Qt's Model/View system. How would parley \
give tooltips for items in the model? This belongs here.
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122877/#review77230
-----------------------------------------------------------
On March 9, 2015, 2:05 p.m., Rahul Chowdhury wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122877/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 2:05 p.m.)
>
>
> Review request for KDE Edu, Inge Wallin and Jeremy Whiting.
>
>
> Repository: libkeduvocdocument
>
>
> Description
> -------
>
> The model classes of parley's editor is moved into libkeduvocdocument. As a result \
> we can have an editor in the library itself, and the applications won't need to \
> keep their separate editors.
>
> Diffs
> -----
>
> CMakeLists.txt 09aed2b
> keduvocdocument/CMakeLists.txt 6eeba12
> keduvocdocument/keduvoccontainermimedata.h PRE-CREATION
> keduvocdocument/keduvoccontainermimedata.cpp PRE-CREATION
> keduvocdocument/keduvoccontainermodel.h PRE-CREATION
> keduvocdocument/keduvoccontainermodel.cpp PRE-CREATION
> keduvocdocument/keduvoclessonmodel.h PRE-CREATION
> keduvocdocument/keduvoclessonmodel.cpp PRE-CREATION
> keduvocdocument/keduvocreadonlycontainermodel.h PRE-CREATION
> keduvocdocument/keduvocreadonlycontainermodel.cpp PRE-CREATION
> keduvocdocument/keduvocvocabularymimedata.h PRE-CREATION
> keduvocdocument/keduvocvocabularymimedata.cpp PRE-CREATION
> keduvocdocument/keduvocvocabularymodel.h PRE-CREATION
> keduvocdocument/keduvocvocabularymodel.cpp PRE-CREATION
> keduvocdocument/keduvocwordclassmodel.h PRE-CREATION
> keduvocdocument/keduvocwordclassmodel.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122877/diff/
>
>
> Testing
> -------
>
> It builds and runs with no errors.
>
>
> Thanks,
>
> Rahul Chowdhury
>
>
--===============3631424519479868249==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122877/">https://git.reviewboard.kde.org/r/122877/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 9th, 2015, 2:59 p.m. MDT, <b>Inge \
Wallin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122877/diff/1/?file=353919#file353919line215" \
style="color: black; font-weight: bold; text-decoration: \
underline;">keduvocdocument/keduvocvocabularymodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">215</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">Qt</span><span class="o">::</span><span \
class="nl">ToolTipRole</span><span class="p">:</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">216</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">///@todo more tooltips?</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">217</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">switch</span> <span class="p">(</span><span \
class="n">entryColumn</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">218</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="nl">WordClass</span><span \
class="p">:</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">219</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">"You can drag and drop words onto their word \
type."</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">220</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="nl">Synonym</span><span \
class="p">:</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">221</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">"Enable the synonym view to edit \
synonyms."</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">222</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="nl">Antonym</span><span \
class="p">:</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">223</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">"Enable the antonym view to edit \
antonyms."</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">224</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A \
tooltip sounds like something that belongs in an application rather than in a \
library. This should probably be in Parley instead of here. Check if it's possible \
to move or if it really needs to be here.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Also check if there are \
more tooltips in other models.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Nope. Tooltips text come from the model in Qt's Model/View system. How \
would parley give tooltips for items in the model? This belongs here.</p></pre> <br \
/>
<p>- Jeremy</p>
<br />
<p>On March 9th, 2015, 2:05 p.m. MDT, Rahul Chowdhury wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Inge Wallin and Jeremy Whiting.</div>
<div>By Rahul Chowdhury.</div>
<p style="color: grey;"><i>Updated March 9, 2015, 2:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The model classes of parley's editor is moved into \
libkeduvocdocument. As a result we can have an editor in the library itself, and the \
applications won't need to keep their separate editors.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It builds and runs with no errors.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(09aed2b)</span></li>
<li>keduvocdocument/CMakeLists.txt <span style="color: grey">(6eeba12)</span></li>
<li>keduvocdocument/keduvoccontainermimedata.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvoccontainermimedata.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvoccontainermodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvoccontainermodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvoclessonmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvoclessonmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocreadonlycontainermodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocreadonlycontainermodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocvocabularymimedata.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocvocabularymimedata.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocvocabularymodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocvocabularymodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocwordclassmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocwordclassmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122877/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3631424519479868249==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic