[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 123887: Port KEditListBox to KEditListWidget
From: "Filipe Saraiva" <filipe () kde ! org>
Date: 2015-05-25 12:32:49
Message-ID: 20150525123249.17589.34751 () mimi ! kde ! org
[Download RAW message or body]
--===============6070632681420000916==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123887/
-----------------------------------------------------------
(Updated May 25, 2015, 12:32 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
Changes
-------
Submitted with commit 0ac0c421ce8d3c2f1c10022e9915bea02543b901 by Filipe Saraiva to \
branch master.
Repository: cantor
Description
-------
KEditListBox is deprecated in KF5. [Documentation \
page](http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKEditListBox.html) \
suggests to port it to KEditListWidget embedded in a QGroupBox.
Diffs
-----
src/backends/R/settings.ui 5e2e98f
src/backends/kalgebra/settings.ui abcc812
src/backends/lua/settings.ui da408d3
src/backends/maxima/settings.ui 2f08f1c
src/backends/octave/settings.ui df18f27
src/backends/python/settings.ui 59c6cf0
src/backends/qalculate/settings.ui 388b5d2
src/backends/sage/settings.ui da631e9
src/backends/scilab/settings.ui e2788ec
Diff: https://git.reviewboard.kde.org/r/123887/diff/
Testing
-------
* Build ok;
* Add some command to some backend and launch the backend - the commands will run \
correctly.
Thanks,
Filipe Saraiva
--===============6070632681420000916==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123887/">https://git.reviewboard.kde.org/r/123887/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh \
Ngo.</div> <div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated May 25, 2015, 12:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 0ac0c421ce8d3c2f1c10022e9915bea02543b901 by Filipe \
Saraiva to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KEditListBox is deprecated in KF5. <a \
href="http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKEditListBox.html" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Documentation page</a> suggests to port it to KEditListWidget embedded in a \
QGroupBox.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Add some command to some backend and launch the backend - the commands will \
run correctly.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/R/settings.ui <span style="color: grey">(5e2e98f)</span></li>
<li>src/backends/kalgebra/settings.ui <span style="color: \
grey">(abcc812)</span></li>
<li>src/backends/lua/settings.ui <span style="color: grey">(da408d3)</span></li>
<li>src/backends/maxima/settings.ui <span style="color: grey">(2f08f1c)</span></li>
<li>src/backends/octave/settings.ui <span style="color: grey">(df18f27)</span></li>
<li>src/backends/python/settings.ui <span style="color: grey">(59c6cf0)</span></li>
<li>src/backends/qalculate/settings.ui <span style="color: \
grey">(388b5d2)</span></li>
<li>src/backends/sage/settings.ui <span style="color: grey">(da631e9)</span></li>
<li>src/backends/scilab/settings.ui <span style="color: grey">(e2788ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123887/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6070632681420000916==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic