[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118310: support for graphic properties of Geogebra objects in KIG
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-07-14 22:30:36
Message-ID: 20140714223036.3846.26939 () probe ! kde ! org
[Download RAW message or body]
--===============0449173302862573334==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118310/#review62348
-----------------------------------------------------------
ping?
- Albert Astals Cid
On mai. 25, 2014, 6:21 a.m., Aniket Anvit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118310/
> -----------------------------------------------------------
>
> (Updated mai. 25, 2014, 6:21 a.m.)
>
>
> Review request for KDE Edu and David Narváez.
>
>
> Repository: kig
>
>
> Description
> -------
>
> This patch enables KIG to read the graphic properties of Geogebra objects from \
> Geogebra worksheets. Here is some explanation about my implementation:
>
> the graphic properties ( lineStyle, pointStyle, lineWidth, color ) are read for \
> each geogebra object. I add an attribute for each property to each of the \
> intermediate representation of each of the objects created using XSLT. Some \
> variables are added to the KigFilterGeogebra class to hold the values of the \
> properties for each of the objects. In the attribute() callback method of the \
> KigFilterGeogebra class , the values of the properties are read ( and suitably \
> mapped to KIG's ) and when the endElement() callback is called a new ObjectDrawer \
> with the last read properties is allocated for this object.
>
> Diffs
> -----
>
> filters/geogebra-filter.h ebf5713
> filters/geogebra-filter.cpp a0fc6b4
> filters/geogebra.xsl e52fc1d
>
> Diff: https://git.reviewboard.kde.org/r/118310/diff/
>
>
> Testing
> -------
>
> Tested! some trouble in the mapping of PointStyles.
>
>
> Thanks,
>
> Aniket Anvit
>
>
--===============0449173302862573334==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118310/">https://git.reviewboard.kde.org/r/118310/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping?</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On maig 25th, 2014, 6:21 a.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated mai. 25, 2014, 6:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch enables KIG to read the graphic properties of Geogebra \
objects from Geogebra worksheets. Here is some explanation about my implementation:
the graphic properties ( lineStyle, pointStyle, lineWidth, color ) are read for each \
geogebra object. I add an attribute for each property to each of the intermediate \
representation of each of the objects created using XSLT. Some variables are added to \
the KigFilterGeogebra class to hold the values of the properties for each of the \
objects. In the attribute() callback method of the KigFilterGeogebra class , the \
values of the properties are read ( and suitably mapped to KIG's ) and when the \
endElement() callback is called a new ObjectDrawer with the last read properties is \
allocated for this object.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested! some trouble in the mapping of PointStyles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/geogebra-filter.h <span style="color: grey">(ebf5713)</span></li>
<li>filters/geogebra-filter.cpp <span style="color: grey">(a0fc6b4)</span></li>
<li>filters/geogebra.xsl <span style="color: grey">(e52fc1d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118310/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0449173302862573334==--
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic