'Review Request 119044: Port to KDE Frameworks and Qt5.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request 119044: Port to KDE Frameworks and Qt5.
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2014-06-30 18:29:25
Message-ID: 20140630182925.17520.58926 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119044/
-----------------------------------------------------------

Review request for KDE Edu and Aleix Pol Gonzalez.

Repository: kanagram

Description
-------

Port to KDE Frameworks and Qt5.

Diffs
-----

  CMakeLists.txt 98903e6ffb7571ab3a9510c806a285418e7b0668 
  src/CMakeLists.txt de841020cdf9ab67f121186a2f2756f4e5b1e547 
  src/cmake/FindKanagramEngine.cmake 0922adba8062b2557b077eba535919cb9452015c 

Diff: https://git.reviewboard.kde.org/r/119044/diff/

Testing
-------

Trying to port kanagram to qt5 and frameworks, but it's unable to find \
sharedkvtmlfiles.h header. It's not getting the includepath needed from the \
target_link_libraries like I thought it should, maybe something wrong with \
libkdeedu's Config.cmake file ?

Thanks,

Jeremy Whiting

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119044/">https://git.reviewboard.kde.org/r/119044/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Jeremy Whiting.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kanagram
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port to KDE Frameworks and Qt5.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Trying to port kanagram to qt5 and frameworks, but it&#39;s unable to \
find sharedkvtmlfiles.h header. It&#39;s not getting the includepath needed from the \
target_link_libraries like I thought it should, maybe something wrong with \
libkdeedu&#39;s Config.cmake file ?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(98903e6ffb7571ab3a9510c806a285418e7b0668)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(de841020cdf9ab67f121186a2f2756f4e5b1e547)</span></li>

 <li>src/cmake/FindKanagramEngine.cmake <span style="color: \
grey">(0922adba8062b2557b077eba535919cb9452015c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119044/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 