[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118942: support for gogebra's tools in kig ( GSoC 14 )
From: David_Narváez <david.narvaez () computer ! org>
Date: 2014-06-27 13:58:07
Message-ID: 20140627135807.18724.71996 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118942/#review61094
-----------------------------------------------------------
filters/geogebra-filter.cpp
<https://git.reviewboard.kde.org/r/118942/#comment42544>
Hi, just for the record: I took a look at this patch already but it is on hold \
because of this mime type handling which made me rethink the whole tool support and I \
haven't made my mind yet. I'll comment again once I have a good alternative or once I \
give up looking for an alternative.
- David Narváez
On June 26, 2014, 6:43 a.m., Aniket Anvit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118942/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 6:43 a.m.)
>
>
> Review request for KDE Edu and David Narváez.
>
>
> Repository: kig
>
>
> Description
> -------
>
> This patch adds support for Geogebra's tool files ( .ggt files ) in kig.
>
>
> Diffs
> -----
>
> filters/geogebra-filter.h ebf5713
> filters/geogebra-filter.cpp d40f976
> filters/geogebra.xsl 668d758
> kig/kig_part.desktop bcc50bf
>
> Diff: https://git.reviewboard.kde.org/r/118942/diff/
>
>
> Testing
> -------
>
> To open a tool file, open them from the open-file dialog ( and not from the \
> types-dialog ). I tested with a tool which takes 2 points and gives a line , \
> midpoint, and a circle from these two points. Tested with another tool which took \
> three points and gave a circle, hyperbola and an ellipse from these points. Only \
> those tools will be supported which contain only the geogebra-objects which are \
> currently supported by kig.
>
> Thanks,
>
> Aniket Anvit
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118942/">https://git.reviewboard.kde.org/r/118942/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118942/diff/1/?file=284659#file284659line56" \
style="color: black; font-weight: bold; text-decoration: \
underline;">filters/geogebra-filter.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KigFilterGeogebra* KigFilterGeogebra::instance()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">51</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> \
</span><span class="k"><span class="hl">return</span></span> <span \
class="n">mime</span> <span class="o">==</span> <span \
class="s">"application/vnd.geogebra.<span \
class="hl">file"</span></span><span class="p"><span \
class="hl">;</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">56</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="k"><span \
class="hl">if</span></span><span class="p"><span class="hl">(</span></span> <span \
class="n">mime</span> <span class="o">==</span> <span \
class="s">"application/vnd.geogebra.<span \
class="hl">tool"</span></span><span class="hl"> </span><span class="p"><span \
class="hl">)</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, just \
for the record: I took a look at this patch already but it is on hold because of this \
mime type handling which made me rethink the whole tool support and I haven't \
made my mind yet. I'll comment again once I have a good alternative or once I \
give up looking for an alternative.</pre> </div>
<br />
<p>- David Narváez</p>
<br />
<p>On June 26th, 2014, 6:43 a.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated June 26, 2014, 6:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for Geogebra's tool files ( .ggt files ) in \
kig.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To open a tool file, open them from the open-file dialog ( and not from \
the types-dialog ). I tested with a tool which takes 2 points and gives a line , \
midpoint, and a circle from these two points. Tested with another tool which took \
three points and gave a circle, hyperbola and an ellipse from these points. Only \
those tools will be supported which contain only the geogebra-objects which are \
currently supported by kig.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/geogebra-filter.h <span style="color: grey">(ebf5713)</span></li>
<li>filters/geogebra-filter.cpp <span style="color: grey">(d40f976)</span></li>
<li>filters/geogebra.xsl <span style="color: grey">(668d758)</span></li>
<li>kig/kig_part.desktop <span style="color: grey">(bcc50bf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118942/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic