[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118959: Fix linking to ncurses
From: "Vadim Zhukov" <persgray () gmail ! com>
Date: 2014-06-27 0:21:15
Message-ID: 20140627002115.11642.86147 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118959/
-----------------------------------------------------------
(Updated June 27, 2014, 12:21 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Repository: analitza
Description
-------
On some systems, libreadline is linked to Curses implementation directly; on other, \
it's not, requiring you to link both Curses and Readline libraries manually.
Also, OpenBSD ships with old libreadline that lacks free_history_entry().
I've added all required checks, and forced linking to NCurses library, too.
Diffs
-----
CMakeLists.txt 09e216f
calgebra/CMakeLists.txt 1cbb06b
calgebra/main.cpp fa045ed
Diff: https://git.reviewboard.kde.org/r/118959/diff/
Testing
-------
OpenBSD/i386-CURRENT
Thanks,
Vadim Zhukov
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118959/">https://git.reviewboard.kde.org/r/118959/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated June 27, 2014, 12:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
analitza
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On some systems, libreadline is linked to Curses implementation \
directly; on other, it's not, requiring you to link both Curses and Readline \
libraries manually.
Also, OpenBSD ships with old libreadline that lacks free_history_entry().
I've added all required checks, and forced linking to NCurses library, too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">OpenBSD/i386-CURRENT</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(09e216f)</span></li>
<li>calgebra/CMakeLists.txt <span style="color: grey">(1cbb06b)</span></li>
<li>calgebra/main.cpp <span style="color: grey">(fa045ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118959/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic