'Re: Review Request 116868: Parley: Fix bug 246198 - Making two words synonyms does not mark file as '

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 116868: Parley: Fix bug 246198 - Making two words synonyms does not mark file as 
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2014-03-18 7:51:13
Message-ID: 20140318075113.4860.28741 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116868/
-----------------------------------------------------------

(Updated March 18, 2014, 7:51 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Amarvir Singh.

Repository: parley

Description
-------

This patch fixes bug 246198 - Making two words synonyms does not mark file as \
modified.

I fixed it as simply as I could, namely by providing a way for the docker widget to \
access the document and mark it as modified.

A better but bigger patch would have been to create a class EditorDockerWidget which \
gives the same access and which would be inherited by all editor docker widgets.  \
That would reduce code duplication a lot but is better done in master.

Diffs
-----

  src/editor/synonymwidget.h 39aa2a0 
  src/editor/synonymwidget.cpp e9c67de 
  src/editor/editor.cpp 334e211 
  src/editor/editor.h e24a99c 

Diff: https://git.reviewboard.kde.org/r/116868/diff/

Testing
-------

Tested with some kvtml files and it works as intended.

Thanks,

Inge Wallin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116868/">https://git.reviewboard.kde.org/r/116868/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Amarvir Singh.</div>
<div>By Inge Wallin.</div>

<p style="color: grey;"><i>Updated March 18, 2014, 7:51 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes bug 246198 - Making two words synonyms does not mark \
file as modified.

I fixed it as simply as I could, namely by providing a way for the docker widget to \
access the document and mark it as modified.

A better but bigger patch would have been to create a class EditorDockerWidget which \
gives the same access and which would be inherited by all editor docker widgets.  \
That would reduce code duplication a lot but is better done in master.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with some kvtml files and it works as intended.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/editor/synonymwidget.h <span style="color: grey">(39aa2a0)</span></li>

 <li>src/editor/synonymwidget.cpp <span style="color: grey">(e9c67de)</span></li>

 <li>src/editor/editor.cpp <span style="color: grey">(334e211)</span></li>

 <li>src/editor/editor.h <span style="color: grey">(e24a99c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116868/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 