'Review of training sessions, milestone 2'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review of training sessions, milestone 2
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2014-03-16 0:36:06
Message-ID: 2563742.I9lTHTlXtc () linux-da92 ! site
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

I tried to create a review request for this but there seems to be a new 
version of the review board and I failed to register any reviewers. So instead 
I'll ask for the review here.

Here is what I wrote on the review board:

This is the patch for Milestone 2 for training sessions in Parley.  This one 
implements configurable sessions.

Notice especially the changes in the practice config dialog. I created a new 
config tab called General, moved most of the so called Advanced settings there 
and renamed the rest of the Advanced settings to Specific, considering that the 
only config option left in there is about the specific training mode "multiple 
choice".

If you want to test the patch, it's done in the practice-sessions branch in 
the parley repo.

	-Inge
[Attachment #5 (unknown)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Sans Serif'; font-size:11pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">I tried to create a review request for this but there seems to be \
a new version of the review board and I failed to register any reviewers. So instead \
I'll ask for the review here.</p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; ">&nbsp;</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">Here is what I wrote on the review board:</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">This is the patch for \
Milestone 2 for training sessions in Parley.  This one implements configurable \
sessions.</p> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Notice especially the changes \
in the practice config dialog. I created a new config tab called General, moved most \
of the so called Advanced settings there and renamed the rest of the Advanced \
settings to Specific, considering that the only config option left in there is about \
the specific training mode &quot;multiple choice&quot;.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">If you want to test the \
patch, it's done in the practice-sessions branch in the parley repo.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; ">&nbsp;</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">	-Inge</p></body></html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 