[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request: Fix some bugs in parley
From: "Frederik Gladhorn" <gladhorn () kde ! org>
Date: 2011-12-30 9:24:49
Message-ID: 20111230092449.19472.54671 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103359/#review9366
-----------------------------------------------------------
Please break it up into three commits. You wrote yourself that it fixes ind=
ependent issues.
Check
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
for coding style. Consistency is really helpful when reading the code :)
src/parleymainwindow.cpp
<http://git.reviewboard.kde.org/r/103359/#comment7725>
I don't mind too much, but there is no reason to change Q_FOREACH to fo=
reach, is there?
src/parleymainwindow.cpp
<http://git.reviewboard.kde.org/r/103359/#comment7726>
Parley follows KDE libs coding style.
{} are mandatory for ifs. Especially when you have an else.
=
Are you sure you don't have to check for the pointer to be invalid? if =
(toolbar && toolbar->objectName() ...)
- Frederik Gladhorn
On Dec. 8, 2011, 8:18 p.m., Jan Gerrit Marker wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103359/
> -----------------------------------------------------------
> =
> (Updated Dec. 8, 2011, 8:18 p.m.)
> =
> =
> Review request for KDE Edu.
> =
> =
> Description
> -------
> =
> * Under some circumstances (close Parley when the welcome screen is opene=
d and start it with a file to open (parley <filename>)) the toolbar of the =
editor mode is not shown. This patch cleans up that code (removes m_hiddenT=
oolbars in ParleyMainwindow as it is not needed) and fixes the visibility o=
f the toolbar.
> * Pressing enter in the last line of the vocabulary table does create a n=
ew line but does not edit the new line.
> * Parley crashes when a new document is opened via "Open Recent" or "Open=
".
> =
> I searched the open Parley bug reports on bugs.kde.org for these issues b=
ut I did not find any report.
> =
> =
> Diffs
> -----
> =
> src/editor/editor.cpp 243eb70 =
> src/parleymainwindow.h 48e6d1a =
> src/parleymainwindow.cpp 4ec0526 =
> src/vocabulary/vocabularyview.cpp 84d91c0 =
> =
> Diff: http://git.reviewboard.kde.org/r/103359/diff/diff
> =
> =
> Testing
> -------
> =
> Fixes all bugs properly for me.
> =
> =
> Thanks,
> =
> Jan Gerrit Marker
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103359/">http://git.reviewboard.kde.org/r/103359/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please break it up into \
three commits. You wrote yourself that it fixes independent issues.
Check
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
for coding style. Consistency is really helpful when reading the code :)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103359/diff/1/?file=42936#file42936line398" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/parleymainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ParleyMainWindow::showDocumentActions(bool open, bool edit)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">398</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">Q_FOREACH</span></span><span class="p">(</span><span \
class="n">KToolBar</span> <span class="o">*</span><span class="n">toolbar</span><span \
class="p">,</span> <span class="n"><span class="hl">m_hiddenT</span>ool<span \
class="hl">b</span>ars</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">398</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">foreach</span></span><span class="hl"> </span><span \
class="p">(</span><span class="n">KToolBar</span> <span class="o">*</span><span \
class="n">toolbar</span><span class="p">,</span> <span class="n"><span \
class="hl">t</span>ool<span class="hl">B</span>ars</span><span class="p"><span \
class="hl">()</span>)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't \
mind too much, but there is no reason to change Q_FOREACH to foreach, is there?</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103359/diff/1/?file=42936#file42936line399" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/parleymainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ParleyMainWindow::showDocumentActions(bool open, bool edit)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">399</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">toolbar</span><span \
class="p"><span class="hl">)</span></span><span class="hl"> </span><span \
class="p"><span class="hl">{</span></span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">399</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">toolbar</span><span \
class="o"><span class="hl">-></span></span><span class="n"><span \
class="hl">objectName</span></span><span class="p"><span \
class="hl">()</span></span><span class="hl"> </span><span class="o"><span \
class="hl">==</span></span><span class="hl"> </span><span class="n"><span \
class="hl">name</span></span><span class="p"><span \
class="hl">)</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Parley \
follows KDE libs coding style. {} are mandatory for ifs. Especially when you have an \
else.
Are you sure you don't have to check for the pointer to be invalid? if (toolbar \
&& toolbar->objectName() ...)</pre> </div>
<br />
<p>- Frederik</p>
<br />
<p>On December 8th, 2011, 8:18 p.m., Jan Gerrit Marker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Jan Gerrit Marker.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2011, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Under some circumstances (close Parley when the welcome screen is \
opened and start it with a file to open (parley <filename>)) the toolbar of the \
editor mode is not shown. This patch cleans up that code (removes m_hiddenToolbars in \
ParleyMainwindow as it is not needed) and fixes the visibility of the \
toolbar.
* Pressing enter in the last line of the vocabulary table does create a new line but \
does not edit the new line.
* Parley crashes when a new document is opened via "Open Recent" or \
"Open".
I searched the open Parley bug reports on bugs.kde.org for these issues but I did not \
find any report.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes all bugs properly for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.cpp <span style="color: grey">(243eb70)</span></li>
<li>src/parleymainwindow.h <span style="color: grey">(48e6d1a)</span></li>
<li>src/parleymainwindow.cpp <span style="color: grey">(4ec0526)</span></li>
<li>src/vocabulary/vocabularyview.cpp <span style="color: \
grey">(84d91c0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103359/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic