[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: [kde-edu]: Re: Review Request: Parley: [PATCH] Modifications for
From: "Massimo Lo Iacono" <massimol () lillinet ! org>
Date: 2011-03-21 23:06:49
Message-ID: 20110321230649.11734.80333 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6623/
-----------------------------------------------------------
(Updated March 21, 2011, 11:06 p.m.)
Review request for KDE-Edu.
Summary (updated)
-------
Hallo.
I have made modifications for dictation option, sound option and little mor=
e stuff.
- Now dictation is an option and not a new mode of practice.
- Removed the 4 file dictation...
- This option is active with "Written", "Mixed Letters" and "Example Senten=
ce" practices.
- Now the language of dictation practice is the second of the pair language=
From/languageTo.
- Bug fixed: no entry for word without a sound file.
- There is an option to play sound file of question at the start of practic=
e.
- There is an option to hide text of question.
- Now it's possible control "Flash Cards" practice mode using only Enter ke=
y without need to use the mouse.
- I fixed o little annoying change of size of practice box (it's ok in Linu=
x, I don't know in Windows or MacOsX).
I created the patch from the 1224006 revision.
Diffs
-----
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-prac=
tice/advancedpracticeoptions.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-prac=
tice/advancedpracticeoptions.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-prac=
tice/advancedpracticeoptions.ui 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/parleymainwind=
ow.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/parleymainwind=
ow.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstr=
actbackendmode.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstr=
actfrontend.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstr=
actwidget.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstr=
actwidget.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/compa=
risonbackendmode.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/compa=
risonmodewidget.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/compa=
risonmodewidget.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conju=
gationbackendmode.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conju=
gationmodewidget.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conju=
gationmodewidget.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/entry=
filter.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/examp=
lesentencebackendmode.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/flash=
cardmodewidget.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/flash=
cardmodewidget.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/gende=
rbackendmode.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/guifr=
ontend.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/guifr=
ontend.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multi=
plechoicebackendmode.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multi=
plechoicebackendmode.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multi=
plechoicedata.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multi=
plechoicemodewidget.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multi=
plechoicemodewidget.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
ice_mainwindow.ui 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
ice_widget_comparison.ui 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
ice_widget_conjugation.ui 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
ice_widget_flashcard.ui 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
ice_widget_multiplechoice.ui 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
ice_widget_written.ui 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
iceoptions.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
iceoptions.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
icestatemachine.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/pract=
icesummarycomponent.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/statu=
stoggle.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/teste=
ntrymanager.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/writt=
enpracticewidget.h 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/writt=
enpracticewidget.cpp 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/settings/parle=
y.kcfg 1224006 =
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/statistics/sta=
tisticsmainwindow.cpp 1224006 =
Diff: http://svn.reviewboard.kde.org/r/6623/diff
Testing
-------
I can successful compile and execute the code with my modifications.
Thanks,
Massimo
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6623/">http://svn.reviewboard.kde.org/r/6623/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Massimo Lo Iacono.</div>
<p style="color: grey;"><i>Updated March 21, 2011, 11:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hallo. I have made modifications for dictation option, sound option and \
little more stuff.
- Now dictation is an option and not a new mode of practice.
- Removed the 4 file dictation...
- This option is active with "Written", "Mixed Letters" and \
"Example Sentence" practices.
- Now the language of dictation practice is the second of the pair \
languageFrom/languageTo.
- Bug fixed: no entry for word without a sound file.
- There is an option to play sound file of question at the start of practice.
- There is an option to hide text of question.
- Now it's possible control "Flash Cards" practice mode using only \
Enter key without need to use the mouse.
- I fixed o little annoying change of size of practice box (it's ok in Linux, I \
don't know in Windows or MacOsX).
I created the patch from the 1224006 revision.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I can successful compile and execute the code with my \
modifications.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-practice/advancedpracticeoptions.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-practice/advancedpracticeoptions.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/configure-practice/advancedpracticeoptions.ui \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/parleymainwindow.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/parleymainwindow.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractbackendmode.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractfrontend.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractwidget.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/abstractwidget.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/comparisonbackendmode.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/comparisonmodewidget.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/comparisonmodewidget.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conjugationbackendmode.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conjugationmodewidget.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/conjugationmodewidget.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/entryfilter.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/examplesentencebackendmode.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/flashcardmodewidget.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/flashcardmodewidget.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/genderbackendmode.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/guifrontend.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/guifrontend.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicedata.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicemodewidget.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/multiplechoicemodewidget.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_mainwindow.ui \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_comparison.ui \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_conjugation.ui \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_flashcard.ui \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_multiplechoice.ui \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practice_widget_written.ui \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practiceoptions.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practiceoptions.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practicestatemachine.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/practicesummarycomponent.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/statustoggle.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/testentrymanager.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.h \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.cpp \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/settings/parley.kcfg \
<span style="color: grey">(1224006)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.cpp \
<span style="color: grey">(1224006)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6623/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic