[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Proposal: make squash-merging the default behavior for gitlab MRs
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2020-10-02 21:38:20
Message-ID: 2791196.N9pk7849qx () xps
[Download RAW message or body]

El divendres, 2 d'octubre de 2020, a les 21:19:02 CEST, Konstantin Kharlamov va escriure:
> On Fri, 2020-10-02 at 11:39 -0600, Nate Graham wrote:
> > Accordingly, I think squash-merging makes sense as the default value to
> > avoid this. People who are comfortable with the "curated MR commit
> > history" workflow will of course still be able to turn it off. IMO it
> > makes more sense to ask experts to turn it off than to ask newcomers and
> > novices to turn it on.
> 
> Please don't. This will result in having many MRs with a valid history to get
> squashed just because people would keep forgetting to uncheck it. Given there
> are much more people who aware of how to work with git history, I think this would
> hurt more than occasionally merging a non-squashed MR from a newcomer.
 
+1, squash by default is bound to break more things than fix.



[prev in list] [next in list] [prev in thread] [next in thread]