[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Who merges Merge Requests, and when?
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2020-06-10 22:27:50
Message-ID: 2927066.ULeDloJWCp () xps
[Download RAW message or body]

El dimecres, 10 de juny de 2020, a les 18:19:36 CEST, Glen Ditchfield va escriure:
> In the Phabricator work flow, I would submit a patch, someone knowledgeable 
> would accept it, and I would `arc land` it.  Clear and simple.
> 
> GitLab doesn't have that "accept" step AFAIK.  The KDE Wiki's Infrastructure/
> GitLab page says "Once the Merge Request is accepted, KDE Developers will 
> merge it for you!"  That is imprecise;  I'm in the Developer group, but I'm 
> just a casual.
> 
> So, I have a couple of MRs in flight:
> 
> https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/1 hasn't 
> attracted any review comments.  I don't think I _should_ merge it, but I think 
> I _can_, which makes me uneasy.
> 
> https://invent.kde.org/pim/kcalutils/-/merge_requests/5 had comments, which I 
> resolved.  So, do I merge it?  Do I wait for both reviewers to upvote it?  
> Does a reviewer merge it?

Nothing has really changed, you could push to git before in phabricator, you can push \
to git now in gitlab, it's just a bit easier because the button is there in the web \
UI.

You have the power, as uncle Ben said, use it wisely.

If merging something makes you uneasy, probably you shouldnn't be merging it and \
should ping other people to help review (or convince yourself that it is right and \
then paying lots of attention to bugs, etc. in case it breaks something).

Cheers,
  albert

> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]