[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Review Request: Add ffmpegthumbnailer for video previews
From: Andreas Scherf <ascherfy () googlemail ! com>
Date: 2010-04-27 13:16:41
Message-ID: 201004271516.42361.ascherfy () googlemail ! com
[Download RAW message or body]
Hi, i added a review for the ffmpegthumbnailer i added into kdemultimedia.
Today it works but i have some trouble using vcmake correctly. It would be
nice if someone could have a look on the cmake files especially the sections
for detecting the dependencies At the moment i use
SET( CMAKE_CXX_FLAGS "-D FFMPEG_SWSCALE_API=1" ) to set the ifdef fields.
I need also some work in some code refinements to polish the c++ source in some
classes. But this is only a first try ...
Cheers
Andreas
["forwarded message" (message/rfc822)]
Delivered-To: ascherfy@googlemail.com
Received: by 10.216.179.12 with SMTP id g12cs107625wem;
Tue, 27 Apr 2010 06:06:35 -0700 (PDT)
Received: by 10.87.20.36 with SMTP id x36mr1666402fgi.14.1272373595457;
Tue, 27 Apr 2010 06:06:35 -0700 (PDT)
Return-Path: <ascherfy@googlemail.com>
Received: from vidsolbach.de (vidsolbach.de [88.198.47.23])
by mx.google.com with ESMTP id d8si8661261fga.16.2010.04.27.06.06.35;
Tue, 27 Apr 2010 06:06:35 -0700 (PDT)
Received-SPF: neutral (google.com: 88.198.47.23 is neither permitted nor denied by \
domain of ascherfy@googlemail.com) client-ip=88.198.47.23;
Authentication-Results: mx.google.com; spf=neutral (google.com: 88.198.47.23 is \
neither permitted nor denied by domain of ascherfy@googlemail.com) \
smtp.mail=ascherfy@googlemail.com
Received: from localhost ([127.0.0.1])
by vidsolbach.de with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.69)
(envelope-from <ascherfy@googlemail.com>)
id 1O6kVn-0005Yw-Qh; Tue, 27 Apr 2010 15:07:44 +0200
Content-Type: text/plain;
charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Review Request: Add ffmpegthumbnailer for video previews
From: "Andreas Scherf" <ascherfy@googlemail.com>
To: "Andreas Scherf" <ascherfy@googlemail.com>,
"kdelibs" <kde-core-devel@kde.org>
Date: Tue, 27 Apr 2010 13:07:39 -0000
Message-ID: <20100427130739.21385.51267@localhost>
X-Authenticated-User: rb@vidsolbach.de
X-Authenticator: login
X-Invalid-HELO: HELO is no FQDN (contains no dot) (See RFC2821 4.1.1.1)
X-Exim-Version: 4.69 (build at 06-Apr-2010 09:43:58)
X-Date: 2010-04-27 15:07:44
X-Connected-IP: 127.0.0.1:55726
X-Message-Linecount: 138
X-Body-Linecount: 128
X-Message-Size: 3674
X-Body-Size: 3281
X-Received-Count: 1
X-Recipient-Count: 2
X-Local-Recipient-Count: 2
X-Local-Recipient-Defer-Count: 0
X-Local-Recipient-Fail-Count: 0
X-Length: 5331
X-UID: 486
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3818/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
This change adds a ffmpegbackend for rendering video thumbnails =
FFMPEG is required for this. =
Diffs
-----
/trunk/KDE/kdemultimedia/CMakeLists.txt 1119516 =
/trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer.h PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer.cpp PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/.directory PRE-CR=
EATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/AUTHORS PRE-CREAT=
ION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog PRE-CRE=
ATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/README PRE-CREATI=
ON =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.h=
PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.c=
pp PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/grayscalefilter.h=
PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/histogram.h PRE-C=
REATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ifilter.h PRE-CRE=
ATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagetypes.h PRE-=
CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagewriter.h PRE=
-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/imagewriterfactor=
y.h PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/jpegwriter.h PRE-=
CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/jpegwriter.cpp PR=
E-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/main.cpp PRE-CREA=
TION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h PR=
E-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp =
PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/pngwriter.h PRE-C=
REATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/pngwriter.cpp PRE=
-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/stringoperations.=
h PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/stringoperations.=
cpp PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h PRE-=
CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.=
h PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.=
cpp PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailerc=
.h PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailerc=
.cpp PRE-CREATION =
/trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbs.desktop PRE-CREATION =
Diff: http://reviewboard.kde.org/r/3818/diff
Testing
-------
Screenshots
-----------
Dolphin with ffmpegthumbs
http://reviewboard.kde.org/r/3818/s/375/
Thanks,
Andreas
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic