[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] KSnapshot bug
From:       Vishesh Handa <handa.vish () gmail ! com>
Date:       2010-03-30 18:34:08
Message-ID: 38ef5bd51003301122x5b5fecf6l21f8686454a8d709 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Yes. I saw it. My solution was quite horrible (and buggy! :(, and Asegio
seems to have a much better solution (committed today). I didn't want to add
an extra member variable and in an attempt to circumvent that I seem to have
produced shitty code.

I'll try to test my patches better from next time. Sorry!

- Vishesh Handa

On Tue, Mar 30, 2010 at 10:52 PM, Aaron J. Seigo <aseigo@kde.org> wrote:

> On March 28, 2010, Vishesh Handa wrote:
> > http://reviewboard.kde.org/r/2980/
>
> a review of this patch was made over 2 days ago, and it can be seen on the
> reviewboard entry link you posted above. that review highlights some issues
> with the patch which need to be attended to.
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>

[Attachment #5 (text/html)]

Yes. I saw it. My solution was quite horrible (and buggy! :(, and Asegio seems to \
have a much better solution (committed today). I didn&#39;t want to add an extra \
member variable and in an attempt to circumvent that I seem to have produced shitty \
code. <br> <br>I&#39;ll try to test my patches better from next time. Sorry!<br><br>- \
Vishesh Handa  <br><br><div class="gmail_quote">On Tue, Mar 30, 2010 at 10:52 PM, \
Aaron J. Seigo <span dir="ltr">&lt;<a \
href="mailto:aseigo@kde.org">aseigo@kde.org</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"><div class="im">On March 28, 2010, Vishesh Handa \
wrote:<br> &gt; <a href="http://reviewboard.kde.org/r/2980/" \
target="_blank">http://reviewboard.kde.org/r/2980/</a><br> <br>
</div>a review of this patch was made over 2 days ago, and it can be seen on the<br>
reviewboard entry link you posted above. that review highlights some issues<br>
with the patch which need to be attended to.<br>
<font color="#888888"><br>
--<br>
Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Qt Development Frameworks<br>
<br>
&gt;&gt; Visit <a href="http://mail.kde.org/mailman/listinfo/kde-devel#unsub" \
target="_blank">http://mail.kde.org/mailman/listinfo/kde-devel#unsub</a> to \
unsubscribe &lt;&lt;<br> </font></blockquote></div><br>



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]