[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] powerdevil-remove-cpufreq.patch
From:       Dario Freddi <drf54321 () gmail ! com>
Date:       2010-03-07 23:28:38
Message-ID: 201003080028.43509.drf54321 () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi Holger,

thank you for this set of patches. Before I go on reviewing them (there are 
some parts that I like and some parts that I actually don't) I would 
appreciate if you could post them on our reviewboard - 
http://reviewboard.kde.org to ease their reviewal. Reviewboard is the place 
where we usually collect and review all patches to KDE svn.

On Sunday 07 March 2010 23:57:37 Holger Macht wrote:
> Remove all CPU frequency scaling code from powerdevil and the kcm
> module. You should never offer those options to the user because he
> might not understand what the impact is. You only want a dynamic
> frequency algorithm which is the default these days (ondemand
> governor). A good explanation is provided in [1].
> 
> Regards,
>  Holger

-- 
-------------------

Dario Freddi
KDE Developer
GPG Key Signature: 511A9A3B

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]